From: sashiko-bot@kernel.org
To: "Sushrut Shree Trivedi" <sushrut.trivedi@oss.qualcomm.com>
Cc: devicetree@vger.kernel.org, robh@kernel.org, conor+dt@kernel.org
Subject: Re: [PATCH] arm64: dts: qcom: qcs6490-rb3gen2-industrial-mezzanine: Disable ASPM for TC9563 switch
Date: Thu, 12 Nov 2026 07:51:20 +0000 [thread overview]
Message-ID: <sashiko-outbox-210631@kernel.org> (raw)
In-Reply-To: <20261112-ik_disable_aspm-v1-1-f43d8ca7703b@oss.qualcomm.com>
Thank you for your contribution! Sashiko AI review found no new issues
in this patch, but noticed 1 related pre-existing issue it does not
introduce:
- [Medium] arm64: dts: qcom: qcs6490-rb3gen2: missing wake-gpios in
&pcie1_port0 [1]
--
commit ba184a8d8b0523b067f0174cb5855f2bdeb4aa59
Author: Sushrut Shree Trivedi <sushrut.trivedi@oss.qualcomm.com>
arm64: dts: qcom: qcs6490-rb3gen2-industrial-mezzanine: Disable ASPM for TC9563 switch
This commit disables ASPM L0s and L1 on the PCIe links for the TC9563
switches on the QCS6490 RB3gen2 Industrial Mezzanine platform.
> diff --git a/arch/arm64/boot/dts/qcom/qcs6490-rb3gen2-industrial-mezzanine.dtso b/arch/arm64/boot/dts/qcom/qcs6490-rb3gen2-industrial-mezzanine.dtso
> index e8780646ab19c..b8d56a216e409 100644
> --- a/arch/arm64/boot/dts/qcom/qcs6490-rb3gen2-industrial-mezzanine.dtso
> +++ b/arch/arm64/boot/dts/qcom/qcs6490-rb3gen2-industrial-mezzanine.dtso
[ ... ]
> @@ -163,6 +175,11 @@ &pcie1 {
> <0x901 &apps_smmu 0x1c99 0x0 0x1>;
> };
>
> +&pcie1_port0 {
> + aspm-no-l0s;
> + aspm-no-l1;
> +};
[Severity: Medium]
This problem wasn't introduced by this patch, but is &pcie1_port0 missing a
wake-gpios property in arch/arm64/boot/dts/qcom/qcs6490-rb3gen2.dts
[1]?
In qcs6490-rb3gen2.dts, &pcie1 configures pcie1_wake_n (gpio3) in pinctrl-0,
while &pcie1_port0 only specifies reset-gpios:
arch/arm64/boot/dts/qcom/qcs6490-rb3gen2.dts:
&pcie1 {
pinctrl-0 = <&pcie1_reset_n>, <&pcie1_wake_n>, <&pcie1_clkreq_n>;
pinctrl-names = "default";
...
};
&pcie1_port0 {
reset-gpios = <&tlmm 2 GPIO_ACTIVE_LOW>;
pcie@0,0 {
Without wake-gpios on &pcie1_port0, the PCIe driver cannot register the
WAKE# interrupt, preventing connected PCIe devices from waking the system
from low-power states.
[1] https://sashiko.dev/#/bug/linux-83ecae7c-c21b-44fd-b7c0-3b2ef2ca245c
--
Sashiko AI review · https://sashiko.dev/#/patchset/20261112-ik_disable_aspm-v1-1-f43d8ca7703b@oss.qualcomm.com?part=1
prev parent reply other threads:[~2026-11-12 7:51 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-12 7:40 [PATCH] arm64: dts: qcom: qcs6490-rb3gen2-industrial-mezzanine: Disable ASPM for TC9563 switch Sushrut Shree Trivedi
2026-11-12 7:51 ` sashiko-bot [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=sashiko-outbox-210631@kernel.org \
--to=sashiko-bot@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=robh@kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
--cc=sushrut.trivedi@oss.qualcomm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.