From: sashiko-bot@kernel.org
To: Kailang <kailang@realtek.com>
Cc: "linux-sound@vger.kernel.org" <linux-sound@vger.kernel.org>
Subject: Re: Remove Headphone MIC support
Date: Thu, 12 Nov 2026 08:07:16 +0000 [thread overview]
Message-ID: <sashiko-outbox-210669@kernel.org> (raw)
In-Reply-To: <3c8129fbfa6d4ee2b464735f2f31dffa@realtek.com>
Thank you for your contribution! Sashiko AI review found 1 potential
issue to consider:
- [Low] ALSA: hda/realtek: missing subject prefix and email text in
commit log
--
commit 5825158cd0bc2543d8e2f6371d06ebd4d7af6e08
Author: Kailang <kailang@realtek.com>
> Remove Headphone MIC support
>
> Hi Takashi,
>
> Dell QC DT unit don't support Headphone MIC.
> This patch was changed model to NO Headphone MIC model.
> This modify also fixed headphone popping noise issue.
> Many Thanks.
>
> BR,
> Kailang
>
> This unit don't support headphone MIC.
> The popping sound will disappear when you remove it.
>
> Fixes: 97272a5704bf ("ALSA: hda/realtek - Fixed Headphone noise issue for Dell QCM1255")
> Signed-off-by: Kailang Yang <kailang@realtek.com>
[Severity: Low]
This isn't a bug, but could the commit metadata and message be cleaned up?
The subject line is missing the "ALSA: hda/realtek:" subsystem prefix and
does not identify the affected Dell Pro QC1255 machines. The changelog
also retains email greeting and sign-off text ("Hi Takashi, ... Many
Thanks. BR, Kailang") that belongs below the "---" separator, followed by
a duplicate paragraph repeating the explanation. Finally, the Author
header uses a single name ("Kailang <kailang@realtek.com>") rather than
the full name in the Signed-off-by trailer ("Kailang Yang
<kailang@realtek.com>").
--
Sashiko AI review · https://sashiko.dev/#/patchset/3c8129fbfa6d4ee2b464735f2f31dffa@realtek.com?part=1
next prev parent reply other threads:[~2026-11-12 8:07 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-12 7:59 Remove Headphone MIC support Kailang
2026-11-12 8:07 ` sashiko-bot [this message]
2026-11-12 12:39 ` Takashi Iwai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=sashiko-outbox-210669@kernel.org \
--to=sashiko-bot@kernel.org \
--cc=kailang@realtek.com \
--cc=linux-sound@vger.kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.