Re: [PATCH v4 1/3] arm64: dts: qcom: nord: Add SoCCP remoteproc DT support for Nord

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 2 potential
issues to consider:
- [Medium] arm64: dts: qcom: nord: undocumented qcom,nord-soccp-pas
  compatible
- [Low] arm64: dts: qcom: nord: commit message describes moving new
  compatible
--

commit 368cfee1a2a184e173c7b4c22c268cf4858fda12
Author: Anurag Pateriya <anurag.pateriya@oss.qualcomm.com>

arm64: dts: qcom: nord: Add SoCCP remoteproc DT support for Nord

This commit adds the SoCCP remoteproc and SMP2P nodes in nord.dtsi and
enables the compatible, clock, and power domains in nord-embedded.dtsi.

> Move the SoCCP compatible to nord-embedded.dtsi to fix binding
> errors reported for the Ride board.

[Severity: Low]
This isn't a bug, but this sentence reads like a changelog note between
patch revisions.  Prior to this commit, neither remoteproc_soccp nor a
SoCCP compatible existed in nord.dtsi, so the compatible is being added in
nord-embedded.dtsi rather than moved from nord.dtsi.

> diff --git a/arch/arm64/boot/dts/qcom/nord-embedded.dtsi b/arch/arm64/boot/dts/qcom/nord-embedded.dtsi
> index 5a1520e436c64..2211171b8c4c0 100644
> --- a/arch/arm64/boot/dts/qcom/nord-embedded.dtsi
> +++ b/arch/arm64/boot/dts/qcom/nord-embedded.dtsi
> @@ -464,6 +464,16 @@ &remoteproc_cdsp3 {
>  			     "nsp";
>  };
>  
> +&remoteproc_soccp {
> +	compatible = "qcom,nord-soccp-pas";

[Severity: Medium]
Is "qcom,nord-soccp-pas" documented in a Devicetree binding schema or
supported by the PAS driver yet?

Neither Documentation/devicetree/bindings/remoteproc/qcom,kaanapali-soccp-pas.yaml
nor Documentation/devicetree/bindings/remoteproc/qcom,nord-pas.yaml lists
"qcom,nord-soccp-pas", and qcom_pas_of_match[] in
drivers/remoteproc/qcom_q6v5_pas.c only matches the Nord ADSP and CDSP0..3
compatibles.  This causes dtbs_check to fail on the Nord embedded device
trees and prevents remoteproc_soccp from binding at runtime.

In addition, remoteproc_soccp in nord.dtsi specifies a single
memory-region = <&soccp_mem>, whereas the existing SoCCP and Nord PAS
binding schemas require two memory-region items.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261112-nord-soccp-dt-v4-0-af6e44e9f397@oss.qualcomm.com?part=1