Re: [PATCH v3 3/4] soc: ti: k3-socinfo: Export SoC registration helper

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential
issue to consider:
- [High] soc: ti: k3-socinfo: missing header for k3_socinfo_register()
  breaks build
--

commit 50190b242a0586e1caa40c20a83d5610007110d5
Author: Moteen Shah <m-shah@ti.com>

soc: ti: k3-socinfo: Export SoC registration helper

This commit splits the JTAG ID decoding and SoC device registration out of
k3_chipinfo_probe() into an exported k3_socinfo_register() helper.

> diff --git a/drivers/soc/ti/k3-socinfo.c b/drivers/soc/ti/k3-socinfo.c
> index e21a2cd14c811..bf0829fb1d61c 100644
> --- a/drivers/soc/ti/k3-socinfo.c
> +++ b/drivers/soc/ti/k3-socinfo.c
> @@ -5,6 +5,8 @@
>   * Copyright (C) 2020 Texas Instruments Incorporated - http://www.ti.com
>   */
>  
> +#include <linux/device.h>
> +#include <linux/export.h>
>  #include <linux/mfd/syscon.h>
>  #include <linux/nvmem-consumer.h>
>  #include <linux/of.h>
> @@ -12,6 +14,7 @@
>  #include <linux/regmap.h>
>  #include <linux/platform_device.h>
>  #include <linux/slab.h>
> +#include <linux/soc/ti/k3-socinfo.h>

[Severity: High]
Was include/linux/soc/ti/k3-socinfo.h omitted from this commit?  Without
that header declaring k3_socinfo_register(), compiling
drivers/soc/ti/k3-socinfo.c fails with a missing header error.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261112081047.1550471-1-m-shah@ti.com?part=3