Re: [PATCH rdma-next v11 9/9] RDMA/mana_ib: Handle error CQEs for kernel QPs

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential
issue to consider:
- [Medium] RDMA/mana_ib: wrong WC status in vendor_error_to_wc_error()
--

commit 3890146d1e1c2dc4555e62f3e8c6c195602b6f98
Author: Konstantin Taranov <kotaranov@microsoft.com>

RDMA/mana_ib: Handle error CQEs for kernel QPs

This commit decodes hardware error CQEs for kernel QPs, defers moving
errored QPs to the ERR state via a workqueue, and cleans up pending CQEs
when resetting or destroying kernel QPs.

> diff --git a/drivers/infiniband/hw/mana/cq.c b/drivers/infiniband/hw/mana/cq.c
> index 3d09ff5e5414c..24dca3b6e5bfc 100644
> --- a/drivers/infiniband/hw/mana/cq.c
> +++ b/drivers/infiniband/hw/mana/cq.c

[ ... ]

> @@ -37,12 +40,30 @@ static enum ib_wc_status vendor_error_to_wc_error(uint32_t vendor_error)
>  	case VENDOR_ERR_TX_ATB_WQE_ACCESS_VIOLATION:
>  	case VENDOR_ERR_TX_ATB_WQE_ADDR_RANGE:
>  	case VENDOR_ERR_TX_ATB_WQE_CONFIG_ERR:
> +	case VENDOR_ERR_TX_RDMA_ATB_CMD_MISS:
> +	case VENDOR_ERR_TX_RDMA_ATB_CMD_IDX_ERROR:
> +	case VENDOR_ERR_TX_RDMA_ATB_CMD_TAG_MISMATCH_ERROR:
> +	case VENDOR_ERR_TX_RDMA_ATB_CMD_PDID_MISMATCH_ERROR:
> +	case VENDOR_ERR_TX_RDMA_ATB_CMD_AR_ERROR:
> +	case VENDOR_ERR_TX_RDMA_ATB_CMD_PT_OVF:
> +	case VENDOR_ERR_TX_RDMA_ATB_CMD_PT_LENGHT_MISMATCH:
> +	case VENDOR_ERR_TX_RDMA_ATB_CMD_ILLEGAL_CMD:
>  	case VENDOR_ERR_RX_ATB_SGE_ADDR_RANGE:
>  	case VENDOR_ERR_RX_ATB_SGE_MISSCONFIG:
>  		return IB_WC_LOC_PROT_ERR;
>  	case VENDOR_ERR_RX_ATB_SGE_ADDR_RIGHT:
>  	case VENDOR_ERR_RX_GFID:
>  		return IB_WC_LOC_ACCESS_ERR;
> +	case VENDOR_ERR_RX_OP_REQ:
> +		return IB_WC_REM_INV_REQ_ERR;
> +	case VENDOR_ERR_RX_ATB_RKEY_MISCONFIG_ERR:
> +	case VENDOR_ERR_RX_ATB_RKEY_ADDR_RIGHT:
> +	case VENDOR_ERR_RX_ATB_RKEY_ADDR_RANGE:
> +	case VENDOR_ERR_RX_REMOTE_ACCESS_NAK:
> +		return IB_WC_REM_ACCESS_ERR;
> +	case VENDOR_ERR_RX_INVALID_REQ_NAK:
> +	case VENDOR_ERR_RX_REMOTE_OP_ERR_NAK:
> +		return IB_WC_REM_OP_ERR;

[Severity: Medium]
Should VENDOR_ERR_RX_INVALID_REQ_NAK return IB_WC_REM_INV_REQ_ERR instead
of IB_WC_REM_OP_ERR?

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261112084716.1483342-1-kotaranov@linux.microsoft.com?part=9