Re: [PATCH v4 1/4] dt-bindings: soc: ti: Document the ti,tda54-mcu-scm-conf

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential
issue to consider:
- [Medium] dt-bindings: soc: ti: unresolved maintainer objection to
  ti,proxy-id
--

commit 5a8bd1f31bfabd409d005d1090df37a55a89dc38
Author: Moteen Shah <m-shah@ti.com>

dt-bindings: soc: ti: Document the ti,tda54-mcu-scm-conf

This commit adds a Device Tree binding schema for the Texas Instruments
TDA54 MCU domain System Control Module configuration register region and
its clock gates.

> diff --git a/Documentation/devicetree/bindings/soc/ti/ti,tda54-mcu-scm-conf.yaml b/Documentation/devicetree/bindings/soc/ti/ti,tda54-mcu-scm-conf.yaml
> new file mode 100644
> index 0000000000000..111cbb739b5f1
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/soc/ti/ti,tda54-mcu-scm-conf.yaml

[ ... ]

> +  ti,proxy-id:
> +    $ref: /schemas/types.yaml#/definitions/uint32
> +    minimum: 0
> +    maximum: 7
> +    description:
> +      Proxy region (0-7) through which this node's clients access
> +      claimable registers and their fault status registers.
> +
> +  "#clock-cells":
> +    const: 1
> +    description:
> +      The cell selects the ePWM time-base clock gate. Values 0 to 12 select
> +      ehrpwm_tbclk0 to ehrpwm_tbclk12, i.e. the gate for ePWM instance N is
> +      specifier N.
> +
> +required:
> +  - compatible
> +  - reg
> +  - ti,proxy-id

[Severity: Medium]
As reported by Krzysztof Kozlowski on v2 [1], is the custom ti,proxy-id
property needed here instead of the standard access-controllers binding?

For a single device where the full 0x20000 region covering all 8 proxies
is mapped from reg, the proxy selection does not describe a board-level
hardware difference, and gating register access per host or VM instance
duplicates Documentation/devicetree/bindings/access-controllers/access-controllers.yaml.

[1] https://lore.kernel.org/r/20261028-inventive-screeching-bettong-9f4240@quoll

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261112091027.1601122-1-m-shah@ti.com?part=1