Re: [PATCH 2/4] s390/dasd: Re-initialize RCD buffer with "V1.0" before every start

[sashiko-bot@kernel.org]

> Under z/VM the Read Configuration Data (RCD) buffer has to start with
> EBCDIC "V1.0" to request the virtual device SNEQ that carries the
> minidisk UIT. The request and the response share the same buffer:
> CP evaluates the magic on the way out and the RCD data is written into
> the same buffer on the way back.
> 
> The magic is only written when the request is built and again in
> read_conf_cb() when the original request fails.
> 
> Several restart paths do not run that callback:
>  - ERP use the same buffer and if the same error occurs again,
>    the ERP restarts the existing ERP request;
>    if a different error occurs, it adds another ERP request.
>    Neither re-initializes the magic.
>  - Terminated (timed out) ERP requests, killed requests and requests
> [ ... ]
> 
> Fixes: 5915a873fcb1 ("[S390] dasd: re-initialize read_conf buffer for retries")
> Cc: stable@vger.kernel.org
> Reviewed-by: Jan Höppner <hoeppner@linux.ibm.com>
> Signed-off-by: Stefan Haberland <sth@linux.ibm.com>

Sashiko has reviewed this patch and found no issues.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261112102608.1057852-1-sth@linux.ibm.com?part=2