Re: [PATCH 3/5] ASoC: fsl_asrc: Fix runtime PM usage count on init failure

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential
issue to consider:
- [Low] ASoC: fsl_asrc: wrong Fixes tag and pm_runtime_get_sync() in
  commit msg
--

commit 503d1e3d04da11b4fe4bd7121c2929541b45d6b1
Author: bui duc phuc <phucduc.bui@gmail.com>

> ASoC: fsl_asrc: Fix runtime PM usage count on init failure
>
> Balance the runtime PM usage count when fsl_asrc_init() fails
> after pm_runtime_get_sync() succeeds.
>
> Fixes: 286d658477a4 ("ASoC: fsl_asrc: register m2m platform device")
> Signed-off-by: bui duc phuc <phucduc.bui@gmail.com>

[Severity: Low]
Commit 286d658477a4 ("ASoC: fsl_asrc: register m2m platform device") only
added fsl_asrc_m2m_init() at the end of fsl_asrc_probe() and did not touch
fsl_asrc_init() or its error path.  The unbalanced runtime PM usage count on
fsl_asrc_init() failure was introduced by commit cab04ab5900f ("ASoC:
fsl_asrc: Don't use devm_regmap_init_mmio_clk"), so the Fixes tag should
point to that commit instead.

Also, fsl_asrc_probe() acquires the reference via pm_runtime_resume_and_get()
rather than pm_runtime_get_sync() since commit d05040741afe ("ASoC: fsl_asrc:
using pm_runtime_resume_and_get to simplify the code").

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261112105116.32274-1-phucduc.bui@gmail.com?part=3