Re: [PATCH v2 2/2] arm64: dts: qcom: shikra: Correct QCE node configuration

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential
issue to consider:
- [Medium] arm64: dts: qcom: shikra: unexplained removal of QCE memory
  interconnect
--

commit accab4d6610b99099fcb37c8fbe0de4933119ef7
Author: Kuldeep Singh <kuldeep.singh@oss.qualcomm.com>

arm64: dts: qcom: shikra: Correct QCE node configuration

This commit updates the fallback compatible string and replaces the memory
interconnect properties with the core clock in the Shikra QCE device tree
node.

> diff --git a/arch/arm64/boot/dts/qcom/shikra.dtsi b/arch/arm64/boot/dts/qcom/shikra.dtsi
> index 0a95ad5a5582c..d5f0ef863173e 100644
> --- a/arch/arm64/boot/dts/qcom/shikra.dtsi
> +++ b/arch/arm64/boot/dts/qcom/shikra.dtsi
> @@ -1208,7 +1208,7 @@ cryptobam: dma-controller@1b04000 {
>  		};
>  
>  		crypto: crypto@1b3a000 {
> -			compatible = "qcom,shikra-qce", "qcom,sm8150-qce", "qcom,qce";
> +			compatible = "qcom,shikra-qce", "qcom,ipq4019-qce", "qcom,qce";
>  			reg = <0x0 0x01b3a000 0x0 0x6000>;
>  			dmas = <&cryptobam 4>, <&cryptobam 5>;
>  			dma-names = "rx", "tx";
> @@ -1219,9 +1219,8 @@ crypto: crypto@1b3a000 {
>  				 <&apps_smmu 0x96 0x0011>,
>  				 <&apps_smmu 0x98 0x0001>,
>  				 <&apps_smmu 0x9f 0x0>;
> -			interconnects = <&system_noc MASTER_CRYPTO_CORE0 0
> -					 &mc_virt SLAVE_EBI_CH0 0>;
> -			interconnect-names = "memory";
> +			clocks = <&rpmcc RPM_SMD_CE1_CLK>;
> +			clock-names = "core";
>  		};

[Severity: Medium]
Was the removal of interconnects and interconnect-names intentional here?

qce_crypto_probe() acquires both the core clock (qce->core) and the "memory"
interconnect path (qce->mem_path), and qce_runtime_resume() votes for
QCE_DEFAULT_MEM_BANDWIDTH on qce->mem_path alongside enabling qce->core.
Without the interconnect properties, the QCE driver no longer scales the
MASTER_CRYPTO_CORE0 to SLAVE_EBI_CH0 path during crypto transfers, and the
commit message does not mention removing it.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261112-shikra_qce_fix-v2-0-2ce112cc2ccf@oss.qualcomm.com?part=2