Re: [PATCH rdma-rc] RDMA/mlx5: Skip vport context query on FW without ib_virt support

[sashiko-bot@kernel.org]

> From: Moshe Shemesh <moshe@nvidia.com>
> 
> Since commit b02289b3d60f ("RDMA: Validate grh_required when handling
> AVs"), mlx5_port_immutable() unconditionally issues
> QUERY_HCA_VPORT_CONTEXT on InfiniBand ports to read grh_required.
> Devices that do not support the InfiniBand virtualization interface
> (ib_virt cleared) are not guaranteed to implement this command. For
> example, Connect-IB with FW 10.10.5020 rejects it and mlx5_ib fails to
> probe:
> 
>   mlx5_core 0000:01:00.0: mlx5_cmd_out_err:810:(pid 731): QUERY_HCA_VPORT_CONTEXT(0x762) op_mod(0x0) failed, status bad operation(0x2), syndrome (0x3590f5), err(-22)
>   infiniband mlx5_0: Couldn't create per-port data
>   mlx5_ib.rdma: probe of mlx5_core.rdma.0 failed with error -12
> 
> All other HCA vport context users in mlx5_ib are already gated on
> [ ... ]
> Reported-by: Tony Battersby <tonyb@cybernetics.com>
> Closes: https://lore.kernel.org/all/064dfa67-8fd4-40f0-b925-6d1e0cd42e6a@cybernetics.com/
> Tested-by: Tony Battersby <tonyb@cybernetics.com>
> Signed-off-by: Moshe Shemesh <moshe@nvidia.com>
> Signed-off-by: Edward Srouji <edwards@nvidia.com>

Sashiko has reviewed this patch and found no issues.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261112-moshe-ib-virt-guard-v1-1-6d2caf8bdb1b@nvidia.com?part=1