From: sashiko-bot@kernel.org
To: "Congjie Zhou" <zcjie0802@qq.com>
Cc: virtualization@lists.linux.dev,
"Michael S. Tsirkin" <mst@redhat.com>,
"Eugenio Perez" <eperezma@redhat.com>
Subject: Re: [PATCH net 1/2] net: napi: add completion with an ordered IRQ mask callback
Date: Thu, 12 Nov 2026 13:52:15 +0000 [thread overview]
Message-ID: <sashiko-outbox-211233@kernel.org> (raw)
In-Reply-To: <tencent_74EA7A2E8BF5758E9C5EF18C9B1CED401D06@qq.com>
> napi_complete_done() can clear SCHED, arm the watchdog and return false
> when deferring hard IRQs. A false return therefore does not guarantee
> that the caller still owns NAPI. Masking interrupts after this return
> can overwrite the interrupt state established by a successor poll.
>
> Add napi_complete_done_with_irq_mask() with a mask callback that runs on
> false-return paths before ownership can be handed off. The callback
> must be non-sleeping, idempotent and leave NAPI state unchanged, since
> a state-update retry may invoke it more than once.
>
> Keep napi_complete_done() as a wrapper without a callback, and inline
> the shared implementation to eliminate the callback path for existing
> callers.
>
> Signed-off-by: Congjie Zhou <zcjie0802@qq.com>
Sashiko has reviewed this patch and found no issues.
--
Sashiko AI review · https://sashiko.dev/#/patchset/tencent_74EA7A2E8BF5758E9C5EF18C9B1CED401D06@qq.com?part=1
next prev parent reply other threads:[~2026-11-12 13:52 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-11 13:36 [BUG] virtio_net: RX stall caused by masking callbacks after NAPI ownership release Congjie Zhou
2026-11-11 13:50 ` [PATCH net 1/2] net: napi: add completion with an ordered IRQ mask callback Congjie Zhou
2026-11-11 13:56 ` netdev-bot+sinfo
2026-11-11 15:08 ` zcj
2026-11-12 13:52 ` sashiko-bot [this message]
2026-11-11 13:50 ` [PATCH net 2/2] virtio_net: mask callbacks before releasing NAPI ownership Congjie Zhou
2026-11-12 13:52 ` sashiko-bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=sashiko-outbox-211233@kernel.org \
--to=sashiko-bot@kernel.org \
--cc=eperezma@redhat.com \
--cc=mst@redhat.com \
--cc=sashiko-reviews@lists.linux.dev \
--cc=virtualization@lists.linux.dev \
--cc=zcjie0802@qq.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.