Re: [PATCH v3 4/5] soundwire: Include the current stream when preparing again

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential
issue to consider:
- [Low] soundwire: missing Fixes trailers for DEPREPARED stream filter
  commits
--

commit 0e099f6ac5f748061c8ae06b3d0b581ba6e28f1f
Author: Bard Liao <yung-chuan.liao@linux.intel.com>

> soundwire: Include the current stream when preparing again
>
> sdw_prepare_stream() accepts a stream in the DEPREPARED state without
> changing its state before parameter computation. However, the generic
> allocator excludes DEPREPARED streams from rate groups and port
> computation, and only includes a CONFIGURED current stream in group
> payload calculations.
>
> Consequently, preparing an existing stream again can reserve bandwidth
> without computing the corresponding transport parameters. The filters
> need to distinguish preparing that stream again from depreparing it.
>
> Pass the prepare context through the group and port helpers. Include
> the current stream during prepare even when it is still DEPREPARED,
> while preserving the filtering of all other runtimes and the behavior
> during deprepare. This supports preparing again without temporarily
> changing stream state.
>
> Signed-off-by: Bard Liao <yung-chuan.liao@linux.intel.com>
> Reviewed-by: Péter Ujfalusi <peter.ujfalusi@linux.intel.com>

[Severity: Low]
This fixes a bug where re-preparing a DEPREPARED stream skips transport and
port parameter computation due to state filters introduced in earlier
commits.  Should this include Fixes tags for the commits that added those
checks:

  Fixes: fdd1faeeec14 ("soundwire: generic_bandwidth_allocation: skip DEPREPARED streams")
  Fixes: 25befdf32aa4 ("soundwire: generic_bandwidth_allocation: count the bandwidth of active streams only")
  Fixes: 62ada17a6217 ("soundwire: only compute port params in specific stream states")

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261112141905.1372770-1-yung-chuan.liao@linux.intel.com?part=4