Re: [RFC PATCH v3 16/20] vfio/pci: Restore device state from slot_reset()

[sashiko-bot@kernel.org]

> A host reset loses device configuration and IRQ state. Add slot_reset()
> to restore the configuration saved at open, discard the old PM snapshot
> and tear down IRQ configuration for userspace to rebuild. Record RESET
> before restoration so failures also report that a reset occurred. Leave
> failed devices blocked.
> 
> Use the locked PCI power helper because native PCI recovery already
> holds pci_bus_sem for reading. Taking it again could deadlock behind a
> queued writer.
> 
> Preserve NoINTx and recovery masking when restoring saved configuration.
> The state saved at open predates the NoINTx correction. Route PM
> restoration through access ops while the device is open. Open and close
> continue to restore state directly.
> 
> Keep the original error_detected-only callback table for Xen PV and EEH-
> enabled builds. Xen treats a missing slot_reset callback as recovered
> but treats NONE from a callback as failure. EEH also uses callback
> presence to decide whether to keep a device. Disabling the new feature
> alone would not preserve these decisions.
> 
> Signed-off-by: Shameer Kolothum <skolothumtho@nvidia.com>

Sashiko has reviewed this patch and found no issues.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261112141632.918954-1-skolothumtho@nvidia.com?part=16