From: sashiko-bot@kernel.org
To: "Rob Clark" <robin.clark@oss.qualcomm.com>,
dri-devel@lists.freedesktop.org
Subject: Re: [PATCH] drm/msm/a8xx: Fixup hw_err_irq messages
Date: Thu, 12 Nov 2026 16:15:19 +0000 [thread overview]
Message-ID: <sashiko-outbox-211484@kernel.org> (raw)
In-Reply-To: <20261112160706.387641-1-robin.clark@oss.qualcomm.com>
Thank you for your contribution! Sashiko AI review found 1 potential
issue to consider:
- [Low] drm/msm/a8xx: missing Fixes: trailer for a8xx_cp_hw_err_irq()
bug fix
--
commit a5cb62925f6bda8ba8bcbb7f74369ec6522ba176
Author: Rob Clark <robin.clark@oss.qualcomm.com>
> drm/msm/a8xx: Fixup hw_err_irq messages
>
> Handle all the pipes, and don't clobber 'status'.
>
> Signed-off-by: Rob Clark <robin.clark@oss.qualcomm.com>
[Severity: Low]
Since this fixes missing pipe fault checks and clobbering of status in
a8xx_cp_hw_err_irq(), should this include a Fixes tag?
Fixes: 288a93200892 ("drm/msm/adreno: Introduce A8x GPU Support")
--
Sashiko AI review · https://sashiko.dev/#/patchset/20261112160706.387641-1-robin.clark@oss.qualcomm.com?part=1
next prev parent reply other threads:[~2026-11-12 16:15 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-12 16:07 [PATCH] drm/msm/a8xx: Fixup hw_err_irq messages Rob Clark
2026-11-12 16:15 ` sashiko-bot [this message]
2026-11-12 17:11 ` Akhil P Oommen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=sashiko-outbox-211484@kernel.org \
--to=sashiko-bot@kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=robin.clark@oss.qualcomm.com \
--cc=sashiko-reviews@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.