Re: [PATCH 5/5] arm64: dts: qcom: pmi632: Add battery fuel gauge node

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 2 potential
issues to consider:
- [Low] arm64: dts: qcom: pmi632: fuel-gauge@4800 violates
  qcom,spmi-pmic.yaml schema
- [Low] arm64: dts: qcom: pmi632: missing io-channels in pmi632_qgauge
  node
--

commit 15ccef39df06d430c96a1c58092319c5e86db8a5
Author: Val Packett <val@packett.cool>

arm64: dts: qcom: pmi632: Add battery fuel gauge node

This commit adds devicetree nodes for the PMI632 qgauge battery fuel gauge
at 0x4800 and the SDAM region at 0xb100.

> diff --git a/arch/arm64/boot/dts/qcom/pmi632.dtsi b/arch/arm64/boot/dts/qcom/pmi632.dtsi
> index 85cef103e00dc..f04d65fb7aabb 100644
> --- a/arch/arm64/boot/dts/qcom/pmi632.dtsi
> +++ b/arch/arm64/boot/dts/qcom/pmi632.dtsi
> @@ -163,11 +163,44 @@ pmi632_adc_tm: adc-tm@3500 {
>  			status = "disabled";
>  		};
>  
> +		pmi632_qgauge: fuel-gauge@4800 {
> +			compatible = "qcom,pmi632-qg";

[Severity: Low]
Does adding fuel-gauge@4800 under pmic@2 break dtbs_check against
Documentation/devicetree/bindings/mfd/qcom,spmi-pmic.yaml?

That schema matches "qcom,pmi632" and sets additionalProperties: false,
but its patternProperties do not list "^fuel-gauge@[0-9a-f]+$" referencing
/schemas/power/supply/qcom,qg.yaml#.

> +
> +			reg = <0x4800>;
> +
> +			interrupts = <0x2 0x48 0x0 IRQ_TYPE_EDGE_BOTH>,
> +				     <0x2 0x48 0x1 IRQ_TYPE_EDGE_BOTH>,
> +				     <0x2 0x48 0x2 IRQ_TYPE_EDGE_RISING>,
> +				     <0x2 0x48 0x3 IRQ_TYPE_EDGE_RISING>,
> +				     <0x2 0x48 0x4 IRQ_TYPE_EDGE_RISING>,
> +				     <0x2 0x48 0x5 IRQ_TYPE_EDGE_RISING>,
> +				     <0x2 0x48 0x6 IRQ_TYPE_EDGE_RISING>;
> +			interrupt-names = "batt-missing",
> +					  "vbat-low",
> +					  "vbat-empty",
> +					  "fifo-done",
> +					  "good-ocv",
> +					  "fsm-state-chg",
> +					  "event";
> +
> +			nvmem = <&pmi632_sdam_2>;
> +
> +			status = "disabled";
> +		};

[Severity: Low]
Should pmi632_qgauge also wire up io-channels = <&pmi632_adc
ADC5_BAT_THERM_100K_PU> and io-channel-names = "batt-therm" here?

Earlier in this series, commit "arm64: dts: qcom: pmi632: Add missing
bat_therm ADC channel" added channel@4a to pmi632_adc for the fuel gauge.
Without io-channels on pmi632_qgauge (or in every board DTS),
qcom_qg_probe() leaves qg->batt_therm NULL, causing temperature reads to
fail with -ENODEV, qg_get_capacity() to fall back to a hardcoded 25 C, and
qg_get_health() to skip temperature fault checks.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261112170841.2189322-1-val@packett.cool?part=5