Re: [PATCH v3 2/3] dt-bindings: bus: ti,omap3-l3-smx: Convert to DT schema

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential
issue to consider:
- [Low] dt-bindings: bus: ti,omap3-l3-smx: non-canonical property order
  and example
--

commit 1d6cabb054788aa85ea27e9a6e910d618ff518a6
Author: Bhargav Joshi <j.bhargav.u@gmail.com>

dt-bindings: bus: ti,omap3-l3-smx: Convert to DT schema

This commit splits the TI OMAP3 L3 SMX interconnect binding out of
Documentation/devicetree/bindings/arm/omap/l3-noc.txt and converts it to a DT
schema under Documentation/devicetree/bindings/bus/ti,omap3-l3-smx.yaml.

> diff --git a/Documentation/devicetree/bindings/bus/ti,omap3-l3-smx.yaml b/Documentation/devicetree/bindings/bus/ti,omap3-l3-smx.yaml
> new file mode 100644
> index 0000000000000..11f0ebb0cdfc2
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/bus/ti,omap3-l3-smx.yaml

[ ... ]

> +properties:
> +  compatible:
> +    items:
> +      - const: ti,omap3-l3-smx
> +      - const: simple-bus
> +
> +  reg:
> +    maxItems: 1
> +
> +  interrupts:
> +    items:
> +      - description: l3-dbg-irq
> +      - description: l3-app-irq
> +
> +  ti,hwmods:
> +    description: hwmod names for each domain.
> +    $ref: /schemas/types.yaml#/definitions/string
> +    const: l3_main
> +    deprecated: true
> +
> +  "#address-cells":
> +    const: 1
> +
> +  "#size-cells":
> +    const: 1
> +
> +  ranges: true
> +
> +patternProperties:
> +  "^.*@[0-9a-f]+$":
> +    type: object
> +
> +required:
> +  - compatible
> +  - reg
> +  - interrupts
> +  - "#address-cells"
> +  - "#size-cells"
> +  - ranges
> +
> +additionalProperties: false
> +
> +examples:
> +  - |
> +    l3-noc@68000000 {
> +        compatible = "ti,omap3-l3-smx", "simple-bus";
> +        reg = <0x68000000 0x10000>;
> +        #address-cells = <1>;
> +        #size-cells = <1>;
> +        ranges;
> +        interrupts = <9>, <10>;
> +        ti,hwmods = "l3_main";
> +    };

[Severity: Low]
Does the example pass scripts/dtc/dt-check-style --mode=strict?

Placing ranges after #address-cells and #size-cells in the example triggers a
[property-order] warning from scripts/dtc/dt-check-style --mode=strict, as
Documentation/devicetree/bindings/dts-coding-style.rst orders properties as
compatible, reg, ranges, standard/common properties, and then vendor-specific
properties.  Per Documentation/devicetree/bindings/writing-schema.rst, the
properties and required sections should follow this same order (moving ranges
right after reg, and moving the vendor-specific ti,hwmods to the end of
properties).

Also, in the example, should the node name be a generic name such as
bus@68000000 (instead of l3-noc@68000000, which refers to the OMAP4+ Arteris
NoC) and omit the deprecated ti,hwmods property?

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261112-ti-l3-noc-v3-0-7281b1af8030@gmail.com?part=2