From: sashiko-bot@kernel.org
To: "Alexey Charkov" <alchark@gmail.com>
Cc: linux-watchdog@vger.kernel.org
Subject: Re: [PATCH v6 3/4] watchdog: Add support for VIA/WonderMedia SoC watchdog functionality
Date: Thu, 12 Nov 2026 19:08:50 +0000 [thread overview]
Message-ID: <sashiko-outbox-211746@kernel.org> (raw)
In-Reply-To: <20261112-vt8500-timer-updates-v6-3-fd1cea645d1f@gmail.com>
Thank you for your contribution! Sashiko AI review found 1 potential
issue to consider:
- [Low] watchdog: vt8500-wdt: missing kernel-parameters.txt entry for
nowayout
--
commit a5067e39729d1dac5a691d15d6ebc0e129c1a8a6
Author: Alexey Charkov <alchark@gmail.com>
watchdog: Add support for VIA/WonderMedia SoC watchdog functionality
This commit adds a built-in auxiliary driver for the VIA/WonderMedia
VT8500 hardware watchdog using the system timer's first match channel.
> diff --git a/drivers/watchdog/vt8500-wdt.c b/drivers/watchdog/vt8500-wdt.c
> new file mode 100644
> index 0000000000000..e0f838fd1d507
> --- /dev/null
> +++ b/drivers/watchdog/vt8500-wdt.c
> @@ -0,0 +1,132 @@
[ ... ]
> +static bool nowayout = WATCHDOG_NOWAYOUT;
> +module_param(nowayout, bool, 0);
> +MODULE_PARM_DESC(nowayout, "Watchdog cannot be stopped once started (default="
> + __stringify(WATCHDOG_NOWAYOUT) ")");
[Severity: Low]
Should vt8500_wdt.nowayout also be documented in
Documentation/admin-guide/kernel-parameters.txt?
Because CONFIG_VT8500_WATCHDOG is a bool Kconfig symbol and the driver is
registered via builtin_driver(), module_param(nowayout, ...) only acts as
a kernel command-line boot parameter rather than a loadable module
parameter.
--
Sashiko AI review · https://sashiko.dev/#/patchset/20261112-vt8500-timer-updates-v6-0-fd1cea645d1f@gmail.com?part=3
next prev parent reply other threads:[~2026-11-12 19:08 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-12 18:55 [PATCH v6 0/4] clocksource/drivers/timer-vt8500: clean up and add watchdog function Alexey Charkov
2026-11-12 18:55 ` [PATCH v6 1/4] clocksource/drivers/timer-vt8500: Add defines for magic constants Alexey Charkov
2026-11-12 18:55 ` [PATCH v6 2/4] clocksource/drivers/timer-vt8500: Prepare for watchdog functionality Alexey Charkov
2026-11-12 18:55 ` [PATCH v6 3/4] watchdog: Add support for VIA/WonderMedia SoC " Alexey Charkov
2026-11-12 19:08 ` sashiko-bot [this message]
2026-11-12 18:55 ` [PATCH v6 4/4] watchdog: vt8500: Add a restart handler Alexey Charkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=sashiko-outbox-211746@kernel.org \
--to=sashiko-bot@kernel.org \
--cc=alchark@gmail.com \
--cc=linux-watchdog@vger.kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.