Re: [PATCHv3 4/4] arm64: dts: socfpga: agilex5: add support for the ECC manager

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential
issue to consider:
- [Low] arm64: dts: socfpga: eccmgr node violates
  altr,socfpga-ecc-manager binding
--

commit 2d0a9122ec3d7d762cb61c5759aa15895402f73d
Author: Dinh Nguyen <dinguyen@kernel.org>

arm64: dts: socfpga: agilex5: add support for the ECC manager

This commit adds the ECC manager node and child ECC nodes for OCRAM and
EMAC0/1/2 to the Agilex5 base device tree.

> diff --git a/arch/arm64/boot/dts/altera/socfpga_agilex5.dtsi b/arch/arm64/boot/dts/altera/socfpga_agilex5.dtsi
> index 161f3d4bbefe8..12d623d4b892e 100644
> --- a/arch/arm64/boot/dts/altera/socfpga_agilex5.dtsi
> +++ b/arch/arm64/boot/dts/altera/socfpga_agilex5.dtsi
> @@ -160,6 +160,75 @@ qspi_clk: qspi-clk {
>  		};
>  	};
>  
> +	eccmgr {
> +		compatible = "altr,socfpga-agilex5-ecc-manager",
> +			     "altr,socfpga-a10-ecc-manager";
> +		altr,sysmgr-syscon = <&sysmgr>;
> +		#address-cells = <1>;
> +		#size-cells = <1>;
> +		interrupt-parent = <&intc>;
> +		interrupts = <GIC_SPI 15 IRQ_TYPE_LEVEL_HIGH>,
> +			     <GIC_SPI 241 IRQ_TYPE_LEVEL_HIGH>,
> +			     <GIC_SPI 95 IRQ_TYPE_EDGE_RISING>,
> +			     <GIC_SPI 120 IRQ_TYPE_EDGE_RISING>,
> +			     <GIC_SPI 8 IRQ_TYPE_LEVEL_HIGH>,
> +			     <GIC_SPI 9 IRQ_TYPE_LEVEL_HIGH>,
> +			     <GIC_SPI 7 IRQ_TYPE_LEVEL_HIGH>;
> +		interrupt-names = "global_sbe", "global_dbe", "io96b0" , "io96b1",
> +				  "sdm_qspi_sbe", "sdm_qspi_dbe", "sdm_seu";

[Severity: Low]
Does this eccmgr node fail make dtbs_check against
Documentation/devicetree/bindings/edac/altr,socfpga-ecc-manager.yaml?

Matching "altr,socfpga-a10-ecc-manager" selects that schema, which does not
document "altr,socfpga-agilex5-ecc-manager" in compatible, limits interrupts
to maxItems: 2 rather than 7, and rejects interrupt-names under
additionalProperties: false.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261112215342.2476801-4-dinguyen@kernel.org?part=1