Re: [PATCH RFC 01/13] drm/gem-shmem: Map pages for the DMA device

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential
issue to consider:
- [Low] drm/gem-shmem: inaccurate commit claim on
  drm_gem_shmem_prime_import_no_map()
--

commit ab22341eb694926c9e7157138a1539d1ee8eaee9
Author: Joseph Telaak <joseph@telaak.dev>

drm/gem-shmem: Map pages for the DMA device

This commit updates the GEM shmem helpers to map, unmap, and attach
DMA-BUF objects using drm_dev_dma_dev() instead of drm_device.dev.

> Of those that do and use the shmem helpers (gud, udl,
> gm12u320, appletbdrm), none maps an object's pages through
> drm_gem_shmem_get_pages_sgt() or imports with
> drm_gem_shmem_prime_import_no_map().
> 
> The first user is powervr_sgx, later in this series: behind gma500 its
> DRM device is an auxiliary device, and its DMA goes through the GPU's
> PCI function.

[Severity: Low]
Is this commit message claim about drm_gem_shmem_prime_import_no_map()
accurate?

Since commit e7a1cbca0b42 ("drm/gem-shmem: Do not map s/g table by
default"), DRM_GEM_SHMEM_DRIVER_OPS sets .gem_prime_import to
drm_gem_shmem_prime_import_no_map, and gud, udl, gm12u320, and
appletbdrm all use DRM_GEM_SHMEM_DRIVER_OPS.  This patch changes their
PRIME imports to attach to the USB host controller DMA device configured
via drm_dev_set_dma_dev() rather than the USB interface device.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261112-powervr-sgx-v1-0-c69b84bac011@telaak.dev?part=1