From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=100.103.45.18 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1794533892; b=IkqA2RFB4VQzTTn1begDVM0MFvyHO5R8AXfRWa6ojq070iCrl+6bMlSiTgIN6f1/4YjC ksnbQSIMFexO0y0Npflc6KZD9Ti3qSbALBiKQljbLdQJn+EKCldotQl/1kGa+FwGiL91k ZW0wZcjNrw8DGYwFchSyTp44/ftTO0+vUrIxxcaJaW6SEp3MOqgjTg3e/xD4kwRz63fQ9 WFH2hoH0QCYZTRUdI6dUgvieQl5lP+ewS7Il0V9yYspglCtaDbHsJz+5pBrSmvZOmr5MF WNsHkMFHczh9aGoULmmtsxvZ61B6KPQzdWDRsFRbmNtuEZEZyhxSN5L4PnS1CspMzWw== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1794533892; h=Received:DKIM-Signature:Message-ID:From:Subject:Reply-To:To:Cc: In-Reply-To:References:Content-Type:Content-Transfer-Encoding:Date; bh=jlDhs3c1raJ/mHbEiJHEARciOgXNbFdNwnMEavYyn5k=; b=4KEbO029K85k9DYzHLsm2oNF0zFcfoqUkG/4IkGP2ZBQSM912s+gmiUijQinsHTYSM6z F0N0+O+WTCPAYdG2kI9SvuqY2LMOLax63qHXlFLsDwhTnVaN0zZCWbY0g035UWKAUEfkQ DjETmamUqi+opdp1cQM8HX8SBVwXNTX+smSpeDzvYJ1krMaoBGfud8eoTVEoA1VNEex4J X3HoHQeU83pUrPM+oQ9TO8i7STce2r1yXcFaRZtrLLtVBhAjPgYZAHAkxZ40LJEBzvzeX kfnTv8Bj5khOEY1stN9QSkokFD5BeLC45xc6sU7JVAyddIHVgZg7iMI8ahaPRKljRiw== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20260515 header.b=ZfQlzg57; arc=none smtp.remote-ip=100.103.45.18 Received: from smtp.kernel.org (quasi.space.kernel.org [100.103.45.18]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 618D1606A31C for ; Fri, 13 Nov 2026 01:38:11 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20260515 header.b=ZfQlzg57 Received: by smtp.kernel.org (Postfix) with ESMTPSA id 3E1531F000C4; Fri, 13 Nov 2026 01:38:11 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1794533891; bh=jlDhs3c1raJ/mHbEiJHEARciOgXNbFdNwnMEavYyn5k=; h=From:Subject:Reply-To:To:Cc:In-Reply-To:References:Date; b=ZfQlzg57AZk9X3vsfUpelx//fAOCraglnrugeZ837RcxAEez9gIUdfkNxUW+ROzXk j57qyaZ8P8ckwMUoypHOKxwcrGQ5d4Z9xTdiJReJC5xqokjhk86i+f1FGwiIGgeZzP RXnrrOdW2Up3QiqEyLBgdlrdG3sk7BRJz8GObwJRKGtQvkhGwDuo31ozpnn6Zwqj9A KIqIoSav7EfKbv40G39pduPVMwklQMS3u3fFyc2/feoikTubjVFlNObT+TGY7Ey2E3 O/iviIKfH77M3KHZN54Rx83mIMOYA6s4sWHg05kuF8OqkX5eEcfmUSzwayDnxRkueR KziWb18iBxkyA== Message-ID: From: sashiko-bot@kernel.org Subject: Re: [PATCH v4 11/12] arm64: dts: qcom: sm6350-lena: Add PM6150L thermals Reply-To: sashiko-reviews@lists.linux.dev To: erebion Cc: dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org, robh@kernel.org, conor+dt@kernel.org In-Reply-To: <20261113-pdx213-upstream-3-v4-11-4b01c50a821c@erebion.eu> References: <20261113-pdx213-upstream-3-v4-0-4b01c50a821c@erebion.eu> <20261113-pdx213-upstream-3-v4-11-4b01c50a821c@erebion.eu> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Date: Fri, 13 Nov 2026 01:38:10 +0000 X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list Thank you for your contribution! Sashiko AI review found 3 potential issues to consider: - [High] arm64: dts: qcom: sm6350-lena: handle used in Author and Signed-off-by - [Medium] arm64: dts: qcom: sm6350-lena: inconsistent RFC_CAM_THERM pinctrl and ADC setup - [Low] arm64: dts: qcom: sm6350-lena: thermal-sensor-msm ordered by label not name -- commit e42ff4c503ef1827973e7803bdff8b39d54aacf7 Author: erebion > arm64: dts: qcom: sm6350-lena: Add PM6150L thermals > > Configure the thermals for the PA_THERM1, MSM_THERM, PA_THERM0, > RFC_CAM_THERM, CAM_FLASH_THERM and QUIET_THERM thermistors connected to > PM6150L. > > Due to hardware constraints we can only register 4 zones with > pm6150l_adc_tm, the other 2 we can register via generic-adc-thermal. > > The trip points can really only be considered as placeholders, more > configuration with cooling etc. can be added later. > > Signed-off-by: erebion [Severity: High] Per Documentation/process/submitting-patches.rst, the Author header and Signed-off-by trailer must use a real human name rather than an account handle ("erebion"). > diff --git a/arch/arm64/boot/dts/qcom/sm6350-sony-xperia-lena-pdx213.dts = b/arch/arm64/boot/dts/qcom/sm6350-sony-xperia-lena-pdx213.dts > index 79097ae409bab..d7a5df04a296c 100644 > --- a/arch/arm64/boot/dts/qcom/sm6350-sony-xperia-lena-pdx213.dts > +++ b/arch/arm64/boot/dts/qcom/sm6350-sony-xperia-lena-pdx213.dts > @@ -61,6 +61,13 @@ key-volume-down { > }; > }; > =20 > + msm_therm_sensor: thermal-sensor-msm { > + compatible =3D "generic-adc-thermal"; > + #thermal-sensor-cells =3D <0>; > + io-channels =3D <&pm6150l_adc ADC5_AMUX_THM2_100K_PU>; > + io-channel-names =3D "sensor-channel"; > + }; > + > touch_en_vreg: regulator-touch-en { [Severity: Low] This isn't a bug, but devicetree coding style orders nodes without unit addresses alphabetically by node name rather than label, so thermal-sensor-msm should be placed after reserved-memory and before thermal-zones. [ ... ] > @@ -392,6 +467,83 @@ &mpss { > status =3D "okay"; > }; > =20 > +&pm6150l_adc { > + pinctrl-0 =3D <&pm6150l_adc_default>; > + pinctrl-names =3D "default"; > + > + channel@4d { > + reg =3D ; > + label =3D "pa_therm1"; > + qcom,hw-settle-time =3D <200>; > + qcom,pre-scaling =3D <1 1>; > + qcom,ratiometric; > + }; > + > + channel@4e { > + reg =3D ; > + label =3D "msm_therm"; > + qcom,hw-settle-time =3D <200>; > + qcom,pre-scaling =3D <1 1>; > + qcom,ratiometric; > + }; > + > + channel@4f { > + reg =3D ; > + label =3D "pa_therm0"; > + qcom,hw-settle-time =3D <200>; > + qcom,pre-scaling =3D <1 1>; > + qcom,ratiometric; > + }; > + > + channel@54 { > + reg =3D ; > + label =3D "rear_cam_flash_therm"; > + qcom,hw-settle-time =3D <200>; > + qcom,pre-scaling =3D <1 1>; > + qcom,ratiometric; > + }; > + > + channel@55 { > + reg =3D ; > + label =3D "quiet_therm"; > + qcom,hw-settle-time =3D <200>; > + qcom,pre-scaling =3D <1 1>; > + qcom,ratiometric; > + }; > +}; [ ... ] > @@ -405,6 +557,14 @@ led-0 { > }; > }; > =20 > +&pm6150l_gpios { > + pm6150l_adc_default: adc-default-state { > + pins =3D "gpio6", "gpio7", "gpio10"; > + function =3D PMIC_GPIO_FUNC_NORMAL; > + bias-high-impedance; > + }; > +}; [Severity: Medium] Is the sixth thermistor (for rear camera) missing from pm6150l_adc, or should gpio6 be dropped from pm6150l_adc_default? The commit message describes six thermistors with two registered via generic-adc-thermal, and pm6150l_adc_default configures three pins (gpio6, gpio7, and gpio10) into high-impedance mode. However, pm6150l_adc only defines five channels (with only two gpio-backed inputs, channel@54 and channel@55, omitting channel@53) and only one generic-adc-thermal sensor (msm_therm_sensor) is registered. --=20 Sashiko AI review =C2=B7 https://sashiko.dev/#/patchset/20261113-pdx213-ups= tream-3-v4-0-4b01c50a821c@erebion.eu?part=3D11