Re: [PATCH v2 2/3] usb: uas: fail command submission on fatal USB errors

[sashiko-bot@kernel.org]

> uas_queuecommand_lck() only treats -ENODEV from uas_submit_urbs() as a
> fatal submission error. When a link drops or an endpoint is disabled
> while hub_wq is frozen, usb_submit_urb() can also fail with -ESHUTDOWN,
> -ENOENT, or -EHOSTUNREACH, causing uas_queuecommand_lck() to return
> SCSI_MLQUEUE_DEVICE_BUSY or queue retry work. In addition, if status or
> data URB submission succeeds before a later URB submission fails,
> uas_queuecommand_lck() either leaks unsubmitted URBs and orphans the
> status URB, or leaves SUBMIT_CMD_URB set and COMMAND_INFLIGHT clear so
> the command never completes.
> 
> Fail commands with DID_NO_CONNECT on -ESHUTDOWN, -ENOENT, and
> -EHOSTUNREACH in uas_queuecommand_lck(), free unsubmitted URBs, and
> unlink any already-submitted status or data URBs outside devinfo->lock.
> 
> Fixes: 26d56a9fcb20 ("usb: uas: fix urb unmapping issue when the uas device is remove during ongoing data transfer")
> Signed-off-by: Sarthak Kukreti <sarthakkukreti@google.com>

Sashiko has reviewed this patch and found no issues.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261113024922.27977-1-sarthakkukreti@google.com?part=2