From: sashiko-bot@kernel.org
To: "Haowen Tu" <tuhaowen@uniontech.com>
Cc: linux-usb@vger.kernel.org
Subject: Re: [PATCH] USB: serial: oti6858: restart polling after TX allocation failure
Date: Fri, 13 Nov 2026 05:31:45 +0000 [thread overview]
Message-ID: <sashiko-outbox-212232@kernel.org> (raw)
In-Reply-To: <2274A9F7B5D45D06+20261113052738.1479779-1-tuhaowen@uniontech.com>
> The status interrupt callback stops polling when it schedules send_data().
> The work function then sets write_urb_in_use before allocating a one-byte
> buffer for the transmit-buffer query. If that allocation fails, it returns
> without clearing the flag or resubmitting the status interrupt URB. With
> no write URB submitted either, nothing restarts polling and queued data
> can no longer make progress.
>
> Use usb_control_msg_recv() to manage the DMA-safe query buffer. Allocation
> failures then follow the existing control-transfer error path, which
> leaves the FIFO untouched, clears write_urb_in_use and restarts polling.
> Adjust the return-value check for the helper's zero-on-success convention.
>
> Fixes: d2126326bd71 ("USB: oti6858: fix DMA buffer on stack")
> Signed-off-by: Haowen Tu <tuhaowen@uniontech.com>
Sashiko has reviewed this patch and found no issues.
--
Sashiko AI review · https://sashiko.dev/#/patchset/2274A9F7B5D45D06+20261113052738.1479779-1-tuhaowen@uniontech.com?part=1
prev parent reply other threads:[~2026-11-13 5:31 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-13 5:27 [PATCH] USB: serial: oti6858: restart polling after TX allocation failure Haowen Tu
2026-11-13 5:31 ` sashiko-bot [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=sashiko-outbox-212232@kernel.org \
--to=sashiko-bot@kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
--cc=tuhaowen@uniontech.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.