From: sashiko-bot@kernel.org
To: "Marc Kleine-Budde" <mkl@pengutronix.de>
Cc: linux-can@vger.kernel.org,
"Oliver Hartkopp" <socketcan@hartkopp.net>,
"Vincent Mailhol" <mailhol@kernel.org>,
"Oleksij Rempel" <o.rempel@pengutronix.de>
Subject: Re: [PATCH net-next 1/7] dt-bindings: net: can: ifi,canfd-1.0: Convert to DT schema
Date: Fri, 13 Nov 2026 07:38:05 +0000 [thread overview]
Message-ID: <sashiko-outbox-212355@kernel.org> (raw)
In-Reply-To: <20261113071325.4092169-2-mkl@pengutronix.de>
Thank you for your contribution! Sashiko AI review found 2 potential
issues to consider:
- [High] dt-bindings: net: can: single-word name in Author and
Signed-off-by
- [Low] dt-bindings: net: can: commit message claims unused
IRQ_TYPE_EDGE_RISING
--
commit 20b578f1ac5dfb3641ca1495585b6a04db880f29
Author: Quchaosheng <quchaosheng000406@163.com>
> dt-bindings: net: can: ifi,canfd-1.0: Convert to DT schema
>
> Convert the IFI CAN-FD controller binding from free-form text to DT
> schema.
>
> Reference can-controller.yaml. interrupts is required: the driver obtains
> it with platform_get_irq().
>
> The example now uses the GIC and irq header defines instead of raw numbers.
> The values are unchanged: GIC_SPI is 0, IRQ_TYPE_NONE is 0 and 1 is
> IRQ_TYPE_EDGE_RISING. Rename the example node from canfd to can so that it
> matches the $nodename pattern in can-controller.yaml.
>
> Signed-off-by: Quchaosheng <quchaosheng000406@163.com>
> Reviewed-by: Rob Herring (Arm) <robh@kernel.org>
> Link: https://patch.msgid.link/20260922102258.138753-2-quchaosheng000406@163.com
> Signed-off-by: Marc Kleine-Budde <mkl@pengutronix.de>
[Severity: High]
Under Documentation/process/submitting-patches.rst, the Author header and
Signed-off-by trailer must use a known real full name with given and family
names separated by a space (for example, Qu Chaosheng or Chaosheng Qu)
rather than a single concatenated word.
> diff --git a/Documentation/devicetree/bindings/net/can/ifi,canfd.yaml b/Documentation/devicetree/bindings/net/can/ifi,canfd.yaml
> new file mode 100644
> index 0000000000000..c8c3105c727b5
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/net/can/ifi,canfd.yaml
[ ... ]
> +examples:
> + - |
> + #include <dt-bindings/interrupt-controller/arm-gic.h>
> + #include <dt-bindings/interrupt-controller/irq.h>
> +
> + can@ff220000 {
> + compatible = "ifi,canfd-1.0";
> + reg = <0xff220000 0x1000>;
> + interrupts = <GIC_SPI 43 IRQ_TYPE_NONE>;
> + };
[Severity: Low]
The commit message states that "1 is IRQ_TYPE_EDGE_RISING", but neither 1
nor IRQ_TYPE_EDGE_RISING appears in the old <0 43 0> example or in this new
example.
--
Sashiko AI review · https://sashiko.dev/#/patchset/20261113071325.4092169-1-mkl@pengutronix.de?part=1
next prev parent reply other threads:[~2026-11-13 7:38 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-13 7:08 [PATCH net-next 0/7] pull-request: can-next 2026-11-13 Marc Kleine-Budde
2026-11-13 7:08 ` [PATCH net-next 1/7] dt-bindings: net: can: ifi,canfd-1.0: Convert to DT schema Marc Kleine-Budde
2026-11-13 7:38 ` sashiko-bot [this message]
2026-11-13 7:45 ` Marc Kleine-Budde
2026-11-17 0:20 ` patchwork-bot+netdevbpf
2026-11-13 7:08 ` [PATCH net-next 2/7] dt-bindings: net: can: bosch,cc770: " Marc Kleine-Budde
2026-11-13 7:08 ` [PATCH net-next 3/7] dt-bindings: net: can: holt,hi311x: " Marc Kleine-Budde
2026-11-13 7:38 ` sashiko-bot
2026-11-13 7:45 ` Marc Kleine-Budde
2026-11-13 7:08 ` [PATCH net-next 4/7] net: can: cc770: update the binding file reference in the driver comment Marc Kleine-Budde
2026-11-13 7:08 ` [PATCH net-next 5/7] dt-bindings: net: can: fsl,mpc5xxx-mscan: Convert to DT schema Marc Kleine-Budde
2026-11-13 7:08 ` [PATCH net-next 6/7] dt-bindings: net: can: convert grcan " Marc Kleine-Budde
2026-11-13 7:08 ` [PATCH net-next 7/7] net: can: grcan: update the binding file reference in the driver comment Marc Kleine-Budde
2026-11-13 7:38 ` sashiko-bot
2026-11-13 7:46 ` Marc Kleine-Budde
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=sashiko-outbox-212355@kernel.org \
--to=sashiko-bot@kernel.org \
--cc=linux-can@vger.kernel.org \
--cc=mailhol@kernel.org \
--cc=mkl@pengutronix.de \
--cc=o.rempel@pengutronix.de \
--cc=sashiko-reviews@lists.linux.dev \
--cc=socketcan@hartkopp.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.