From: sashiko-bot@kernel.org
To: "Filip Gołaś" <filip.golas@3mdeb.com>
Cc: linux-hwmon@vger.kernel.org
Subject: Re: [PATCH 1/3] platform/x86: dasharo-acpi: Extract dasharo_call() from dasharo_read_channel()
Date: Fri, 13 Nov 2026 07:48:18 +0000 [thread overview]
Message-ID: <sashiko-outbox-212368@kernel.org> (raw)
In-Reply-To: <20261113074347.2301465-2-filip.golas@3mdeb.com>
> Move the ACPI method evaluation out of dasharo_read_channel() into a new
> dasharo_call() helper, which additionally accepts up to two extra integer
> arguments after the channel's group and index. This allows the upcoming
> write and fan curve support to reuse the same code path.
>
> No functional change intended.
>
> Signed-off-by: Filip Gołaś <filip.golas@3mdeb.com>
Sashiko has reviewed this patch and found no issues.
--
Sashiko AI review · https://sashiko.dev/#/patchset/20261113074347.2301465-1-filip.golas@3mdeb.com?part=1
next prev parent reply other threads:[~2026-11-13 7:48 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-13 7:43 [PATCH 0/3] platform/x86: dasharo-acpi: Add fan control Filip Gołaś
2026-11-13 7:43 ` [PATCH 1/3] platform/x86: dasharo-acpi: Extract dasharo_call() from dasharo_read_channel() Filip Gołaś
2026-11-13 7:48 ` sashiko-bot [this message]
2026-11-13 7:43 ` [PATCH 2/3] platform/x86: dasharo-acpi: Add fan mode and PWM write support Filip Gołaś
2026-11-13 7:54 ` sashiko-bot
2026-11-13 7:43 ` [PATCH 3/3] platform/x86: dasharo-acpi: Add EC fan curve support Filip Gołaś
2026-11-13 8:05 ` sashiko-bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=sashiko-outbox-212368@kernel.org \
--to=sashiko-bot@kernel.org \
--cc=filip.golas@3mdeb.com \
--cc=linux-hwmon@vger.kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.