Re: [PATCH v2 1/3] CI_ONLY: Hold a device reference across deferred VM

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential
issue to consider:
- [Low] drm/xe: missing Fixes trailer and truncated CI_ONLY commit
  subject
--

commit 5dc8382fd711cc6e72eaaab388a621fd70e80c06
Author: Arvind Yadav <arvind.yadav@intel.com>

> CI_ONLY: Hold a device reference across deferred VM
>
> xe_vm_free() queues vm_destroy_work_func() and returns.
> drm_gpuvm_free() then drops its device reference, but the worker
> still accesses device state while finishing VM destruction.
>
> Take a device reference before queueing the work and release it
> after the worker has finished using the device.
>
> Run the worker on the module-lifetime destroy workqueue. Releasing
> the last device reference can call xe_device_destroy(), which drains
> xe->destroy_wq. Running on that per-device workqueue would make the
> worker wait for itself.
>
> v3:
> - Move final VM destruction to the module-lifetime destroy workqueue
>   in this patch to avoid self-deadlock on the last device put. (Sashiko)
>
> Signed-off-by: Arvind Yadav <arvind.yadav@intel.com>

[Severity: Low]
Since this fixes a device-lifetime bug in deferred teardown, should the
commit message include a Fixes tag?

  Fixes: 61e18525023a ("drm/xe: Route deferred xe_vma/xe_vm teardown off system_dfl_wq")

Also, the subject line still carries a test prefix instead of "drm/xe:" and
is cut off at the end.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261113073549.352746-1-arvind.yadav@intel.com?part=1