From: sashiko-bot@kernel.org
To: "Yong Liu" <pkfxxxing@gmail.com>
Cc: linux-rdma@vger.kernel.org
Subject: Re: [PATCH v5 1/3] RDMA/srpt: Initialize commands before returning BUSY
Date: Fri, 13 Nov 2026 08:52:11 +0000 [thread overview]
Message-ID: <sashiko-outbox-212471@kernel.org> (raw)
In-Reply-To: <20261113083848.1517595-2-pkfxxxing@gmail.com>
> srpt_get_send_ioctx() clears ioctx->cmd, but descriptor parsing can fail
> before target_init_cmd() is called. The error path then calls
> target_send_busy(), which dereferences the NULL cmd->se_tfo pointer.
> A remote initiator can trigger this by submitting a command with an
> invalid descriptor table.
>
> Initialize the command before sending BUSY on descriptor parsing errors.
> Do not request an acknowledgment reference since the command will not
> be submitted to target core.
>
> Fixes: 8b8807b9e982 ("scsi: RDMA/srpt: Fix handling of command / TMF submission failure")
> Cc: stable@vger.kernel.org
> Signed-off-by: Yong Liu <pkfxxxing@gmail.com>
Sashiko has reviewed this patch and found no issues.
--
Sashiko AI review · https://sashiko.dev/#/patchset/20261113083848.1517595-1-pkfxxxing@gmail.com?part=1
next prev parent reply other threads:[~2026-11-13 8:52 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-10 3:08 [PATCH 0/1] RDMA/srpt: Fix read underflow information disclosure liuyong
2026-11-10 3:08 ` [PATCH 1/1] RDMA/srpt: Limit read data transfers to the command length liuyong
2026-11-10 3:33 ` sashiko-bot
2026-11-10 5:28 ` [PATCH v2] " liuyong
2026-11-10 5:48 ` sashiko-bot
2026-11-11 0:54 ` Bart Van Assche
2026-11-11 6:28 ` liuyong
2026-11-11 6:53 ` [PATCH v3] RDMA/srpt: Prevent uninitialized read buffer disclosure liuyong
2026-11-11 7:27 ` sashiko-bot
2026-11-12 9:41 ` [PATCH v4] " liuyong
2026-11-12 10:07 ` sashiko-bot
2026-11-12 21:33 ` Bart Van Assche
2026-11-13 8:38 ` [PATCH v5 0/3] RDMA/srpt: Fix command initialization and " Yong Liu
2026-11-13 8:38 ` [PATCH v5 1/3] RDMA/srpt: Initialize commands before returning BUSY Yong Liu
2026-11-13 8:52 ` sashiko-bot [this message]
2026-11-13 8:38 ` [PATCH v5 2/3] scsi: target: Clear all control read scatterlist entries Yong Liu
2026-11-13 8:46 ` sashiko-bot
2026-11-13 8:38 ` [PATCH v5 3/3] RDMA/srpt: Prevent uninitialized read buffer disclosure Yong Liu
2026-11-13 8:57 ` sashiko-bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=sashiko-outbox-212471@kernel.org \
--to=sashiko-bot@kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=pkfxxxing@gmail.com \
--cc=sashiko-reviews@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.