Re: [PATCH v3 6/6] arm64: dts: qcom: hamoa: add thermal hw-bin support

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential
issue to consider:
- [Medium] arm64: dts: qcom: hamoa: leftover temperature overrides
  shadow temperature-bin
--

commit 35a11d22a7dfa97cb85bfddd513a803ab8607fca
Author: Amit Kucheria <amit.kucheria@oss.qualcomm.com>

arm64: dts: qcom: hamoa: add thermal hw-bin support

This commit adds the i-temp nvmem cell to hamoa.dtsi, wires the tsens
controllers to it, and switches the GPU passive trip points to use
temperature-bin and thermal-hw-bin instead of board-specific overrides.

> diff --git a/arch/arm64/boot/dts/qcom/hamoa.dtsi b/arch/arm64/boot/dts/qcom/hamoa.dtsi
> index 443c1a5c212d9..e25729ff23c87 100644
> --- a/arch/arm64/boot/dts/qcom/hamoa.dtsi
> +++ b/arch/arm64/boot/dts/qcom/hamoa.dtsi

[ ... ]

> @@ -9751,7 +9769,8 @@ map0 {
>  
>  			trips {
>  				gpuss0_alert0: trip-point0 {
> -					temperature = <95000>;
> +					temperature-bin = <95000>, <105000>;
> +					thermal-hw-bin = <0x1>, <0x2>;
>  					hysteresis = <1000>;
>  					type = "passive";
>  				};

[Severity: Medium]
Should the GPU trip-point0 temperature overrides also be removed from
hamoa-advantech-som-db5830.dts, hamoa-som-db5830.dts, and
purwa-iot-evk.dts?

Those boards include hamoa.dtsi and still set temperature = <105000> on
their GPU trip-point0 nodes.  Because temperature and temperature-bin are
distinct properties, the compiled DTBs retain both on the same trip node,
which violates the oneOf schema constraint in thermal-zones.yaml and causes
thermal_of_trip_read_temperature() to read the scalar temperature property
first, bypassing temperature-bin selection on standard-bin parts.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261113-thermal_bin-v3-0-878df6eef8bc@oss.qualcomm.com?part=6