From: sashiko-bot@kernel.org
To: "James Hilliard" <james.hilliard1@gmail.com>
Cc: linux-serial@vger.kernel.org
Subject: Re: [PATCH v13 3/8] serial: 8250_omap: serialize RX DMA completion and flushing
Date: Fri, 13 Nov 2026 10:04:58 +0000 [thread overview]
Message-ID: <sashiko-outbox-212598@kernel.org> (raw)
In-Reply-To: <20261113-submit-serial-8250-dma-cancel-v1-v13-3-b857f2617ece@gmail.com>
> Moving RX DMA locking out of __dma_rx_do_complete() left the DMA
> completion callback calling it without rx_dma_lock. Shutdown and runtime
> suspend flush RX under rx_dma_lock but without the port lock, allowing
> these paths to overlap the callback's buffer accounting and flip-buffer
> insertion. RX submission and UART interrupt handling also require the
> port lock.
>
> Take rx_dma_lock inside the port lock in the completion callback. Hold
> the port lock around the shutdown and runtime-suspend flushes, matching
> the existing interrupt-path lock order. Assert both locks in the common
> completion helper and the port lock at the flush entry point.
>
> Fixes: 789898416749 ("serial: 8250: 8250_omap: Move locking out from __dma_rx_do_complete()")
> Reviewed-by: Raul E Rangel <rrangel@chromium.org>
> Signed-off-by: James Hilliard <james.hilliard1@gmail.com>
Sashiko has reviewed this patch and found no issues.
--
Sashiko AI review · https://sashiko.dev/#/patchset/20261113-submit-serial-8250-dma-cancel-v1-v13-0-b857f2617ece@gmail.com?part=3
next prev parent reply other threads:[~2026-11-13 10:04 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-13 9:53 [PATCH v13 0/8] serial: 8250: serialize DMA cancellation with buffer reuse James Hilliard
2026-11-13 9:53 ` [PATCH v13 1/8] serial: 8250_omap: separate locked TX DMA completion processing James Hilliard
2026-11-13 9:58 ` sashiko-bot
2026-11-13 9:53 ` [PATCH v13 2/8] serial: serialize asynchronous write wakeups with the port lock James Hilliard
2026-11-13 10:06 ` sashiko-bot
2026-11-13 9:53 ` [PATCH v13 3/8] serial: 8250_omap: serialize RX DMA completion and flushing James Hilliard
2026-11-13 10:04 ` sashiko-bot [this message]
2026-11-13 9:53 ` [PATCH v13 4/8] serial: 8250_omap: quiesce DMA IRQ handling before shutdown James Hilliard
2026-11-13 10:00 ` sashiko-bot
2026-11-13 9:53 ` [PATCH v13 5/8] serial: core: allow drivers to reserve flushed transmit storage James Hilliard
2026-11-13 9:53 ` [PATCH v13 6/8] serial: 8250: drain canceled TX DMA before reusing its buffer James Hilliard
2026-11-13 9:53 ` [PATCH v13 7/8] serial: 8250: retire canceled RX DMA before reusing the receive buffer James Hilliard
2026-11-13 9:53 ` [PATCH v13 8/8] serial: 8250: retain DMA resources when termination fails James Hilliard
2026-11-13 10:06 ` sashiko-bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=sashiko-outbox-212598@kernel.org \
--to=sashiko-bot@kernel.org \
--cc=james.hilliard1@gmail.com \
--cc=linux-serial@vger.kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.