Re: [PATCH v2 3/8] MIPS: Loongson64: dts: ls7a-pch: Add missing #address-cells to interrupt controllers

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential
issue to consider:
- [Low] MIPS: dts: loongson: invalid #address-cells on ls7a-lpc node
--

commit b3cb4b22fb7d7fa764f95bec26fd2bfb7137915e
Author: Rong Zhang <rongrong@oss.cipunited.com>

MIPS: Loongson64: dts: ls7a-pch: Add missing #address-cells to interrupt controllers

This commit adds #address-cells = <0> properties to the pic and lpc
interrupt-controller nodes in ls7a-pch.dtsi.

> diff --git a/arch/mips/boot/dts/loongson/ls7a-pch.dtsi b/arch/mips/boot/dts/loongson/ls7a-pch.dtsi
> index f304f99946f16..28038b8cdd146 100644
> --- a/arch/mips/boot/dts/loongson/ls7a-pch.dtsi
> +++ b/arch/mips/boot/dts/loongson/ls7a-pch.dtsi

[ ... ]

> @@ -26,6 +27,7 @@ lpc: interrupt-controller@10002000 {
>  			interrupt-parent = <&pic>;
>  			interrupts = <19 IRQ_TYPE_LEVEL_HIGH>;
>  			#interrupt-cells = <2>;
> +			#address-cells = <0>;
>  		};
>  
>  		ls7a_uart0: serial@10080000 {

[Severity: Low]
Does adding #address-cells to the lpc node break dtbs_check schema
validation?

Documentation/devicetree/bindings/interrupt-controller/loongson,pch-lpc.yaml
sets additionalProperties: false and does not define #address-cells.
Unlike pic, lpc is not referenced by any interrupt-map property, so dtc's
check_interrupt_map() does not warn about it.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261113-mips-ls7a-wdt-v2-0-e8abd6b2f77c@oss.cipunited.com?part=3