From: sashiko-bot@kernel.org
To: "Cezary Rojewski" <cezary.rojewski@intel.com>,
linux-sound@vger.kernel.org
Subject: Re: [PATCH 01/11] ASoC: Intel: avs: Do not skip error reporting when an IPC timeouts
Date: Fri, 13 Nov 2026 11:37:11 +0000 [thread overview]
Message-ID: <sashiko-outbox-212730@kernel.org> (raw)
In-Reply-To: <20261113113840.3067489-2-cezary.rojewski@intel.com>
Thank you for your contribution! Sashiko AI review found 1 potential
issue to consider:
- [Low] ASoC: Intel: avs: missing Fixes: trailer for IPC timeout error
logging fix
--
commit 7616ba37e434bf822d649f2b888e0cc7892fe0f3
Author: Cezary Rojewski <cezary.rojewski@intel.com>
> ASoC: Intel: avs: Do not skip error reporting when an IPC timeouts
>
> If an IPC timeouts nothing is printed as avs_dsp_do_send_msg() exits
> early. This makes it harder to assess and debug IPC failures. Have a
> variable to separate "should copy reply?" subject from debug printing
> one.
>
> Signed-off-by: Cezary Rojewski <cezary.rojewski@intel.com>
[Severity: Low]
Commit 26033ae6bd89 ("ASoC: Intel: avs: Move IPC error messages one level down")
moved IPC error logging from the callers into avs_dsp_do_send_msg() after the
early return on avs_ipc_wait_busy_completion() failure. Should this include a
Fixes: tag for that commit?
Fixes: 26033ae6bd89 ("ASoC: Intel: avs: Move IPC error messages one level down")
--
Sashiko AI review · https://sashiko.dev/#/patchset/20261113113840.3067489-1-cezary.rojewski@intel.com?part=1
next prev parent reply other threads:[~2026-11-13 11:37 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-13 11:38 [PATCH 00/11] ASoC: Intel: avs: Renames and debug prints Cezary Rojewski
2026-11-13 11:38 ` [PATCH 01/11] ASoC: Intel: avs: Do not skip error reporting when an IPC timeouts Cezary Rojewski
2026-11-13 11:37 ` sashiko-bot [this message]
2026-11-13 11:38 ` [PATCH 02/11] ASoC: Intel: avs: Do not skip errors from avs_path_pause() Cezary Rojewski
2026-11-13 11:38 ` [PATCH 03/11] ASoC: Intel: avs: Have one location for dumping path-errors Cezary Rojewski
2026-11-13 11:38 ` [PATCH 04/11] ASoC: Intel: avs: Small registers cleanup Cezary Rojewski
2026-11-13 11:38 ` [PATCH 05/11] ASoC: Intel: avs: Enrich missing-format and token-parsing messages Cezary Rojewski
2026-11-13 11:38 ` [PATCH 06/11] ASoC: Intel: avs: Unify code style for platform_device_id arrays Cezary Rojewski
2026-11-13 11:38 ` [PATCH 07/11] ASoC: Intel: avs: Streamline topology parser names Cezary Rojewski
2026-11-13 11:38 ` [PATCH 08/11] ASoC: Intel: avs: Streamline wording used for board configs Cezary Rojewski
2026-11-13 11:38 ` [PATCH 09/11] ASoC: Intel: avs: Streamline naming of hw_params variables Cezary Rojewski
2026-11-13 11:38 ` [PATCH 10/11] ASoC: Intel: avs: Streamline spacing used in the avs_ids table Cezary Rojewski
2026-11-13 11:38 ` [PATCH 11/11] ASoC: Intel: avs: Remove soc-acpi-intel-match include Cezary Rojewski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=sashiko-outbox-212730@kernel.org \
--to=sashiko-bot@kernel.org \
--cc=cezary.rojewski@intel.com \
--cc=linux-sound@vger.kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.