Re: [PATCH v5 4/5] HACK: Always fallback

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential
issue to consider:
- [Medium] drm/xe/display: debug return false in
  xe_display_bo_fbdev_prefer_stolen()
--

commit 197e9b8f5e53e32742d9ef6f6fe6fad7574e57e8
Author: Maarten Lankhorst <dev@lankhorst.se>

HACK: Always fallback

This commit adds an unconditional return false to
xe_display_bo_fbdev_prefer_stolen().

> diff --git a/drivers/gpu/drm/xe/display/xe_display_bo.c b/drivers/gpu/drm/xe/display/xe_display_bo.c
> index 9385026a80b97..d78d893210c4f 100644
> --- a/drivers/gpu/drm/xe/display/xe_display_bo.c
> +++ b/drivers/gpu/drm/xe/display/xe_display_bo.c
> @@ -142,6 +142,8 @@ bool xe_display_bo_fbdev_prefer_stolen(struct xe_device *xe, unsigned int size)
>  	if (XE_DEVICE_WA(xe, 22019338487_display))
>  		return false;
>  
> +	return false;

[Severity: Medium]
Was this temporary debugging change left in the series by mistake?

Returning false unconditionally here makes the stolen->size check below
unreachable, renders the preceding platform and workaround checks
redundant, and causes initial_plane_bo() to always discard the initial
BIOS framebuffer on integrated platforms when CONFIG_FRAMEBUFFER_CONSOLE
and CONFIG_DRM_FBDEV_EMULATION are enabled.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261113124453.144408-7-dev@lankhorst.se?part=4