All of lore.kernel.org
 help / color / mirror / Atom feed
From: sashiko-bot@kernel.org
To: "Onur Özkan" <work@onurozkan.dev>, dri-devel@lists.freedesktop.org
Cc: ojeda@kernel.org, gary@garyguo.net
Subject: Re: [PATCH v8 1/3] drm/tyr: clear stale IRQ state before soft reset
Date: Fri, 13 Nov 2026 14:40:19 +0000	[thread overview]
Message-ID: <sashiko-outbox-213000@kernel.org> (raw)
In-Reply-To: <20261113-tyr-reset-impl-v8-1-2ee298ac9808@onurozkan.dev>

Thank you for your contribution! Sashiko AI review found 1 potential
issue to consider:
- [Low] drm/tyr: missing Fixes: trailer for issue_soft_reset() stale IRQ
  fix
--

commit e053765c9b79d29e4e4daed59084849814476fe4
Author: Onur Özkan <work@onurozkan.dev>

> drm/tyr: clear stale IRQ state before soft reset
>
> Previous reset may leave the reset completed IRQ set which can make the
> poll return too early.
>
> Clear the IRQ first so the driver waits for the current reset to
> complete.
>
> Reviewed-by: Daniel Almeida <daniel.almeida@collabora.com>
> Reviewed-by: Boris Brezillon <boris.brezillon@collabora.com>
> Signed-off-by: Onur Özkan <work@onurozkan.dev>

[Severity: Low]
This looks like a bug fix for issue_soft_reset() polling.  Should this
include a Fixes: tag, such as:

  Fixes: cf4fd52e3236 ("rust: drm: Introduce the Tyr driver for Arm Mali GPUs")

or:

  Fixes: 6ea52b6d8f33 ("drm/tyr: use read_poll_timeout")

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261113-tyr-reset-impl-v8-0-2ee298ac9808@onurozkan.dev?part=1

  reply	other threads:[~2026-11-13 14:40 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-13 14:32 [PATCH v8 0/3] drm/tyr: GPU reset infrastructure Onur Özkan
2026-11-13 14:32 ` [PATCH v8 1/3] drm/tyr: clear stale IRQ state before soft reset Onur Özkan
2026-11-13 14:40   ` sashiko-bot [this message]
2026-11-13 14:32 ` [PATCH v8 2/3] drm/tyr: add GPU reset infrastructure Onur Özkan
2026-11-13 14:47   ` sashiko-bot
2026-11-13 14:32 ` [PATCH v8 3/3] drm/tyr: put iomem behind the hardware gate Onur Özkan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=sashiko-outbox-213000@kernel.org \
    --to=sashiko-bot@kernel.org \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=gary@garyguo.net \
    --cc=ojeda@kernel.org \
    --cc=sashiko-reviews@lists.linux.dev \
    --cc=work@onurozkan.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.