From: sashiko-bot@kernel.org
To: "Stian Halseth" <stian@itx.no>
Cc: sparclinux@vger.kernel.org, linux-trace-kernel@vger.kernel.org
Subject: Re: [PATCH v2 3/4] sparc64: kprobes: Resume after a delay slot at the saved next PC
Date: Fri, 13 Nov 2026 14:47:03 +0000 [thread overview]
Message-ID: <sashiko-outbox-213010@kernel.org> (raw)
In-Reply-To: <20261113144057.1697874-4-stian@itx.no>
Thank you for your contribution! Sashiko AI review found 1 potential
issue to consider:
- [Low] sparc64: kprobes: missing Fixes trailer for relbranch_fixup()
delay slot fix
--
commit a946035b56bae1c0df38ae8f1a539756818bbb78
Author: Stian Halseth <stian@itx.no>
> sparc64: kprobes: Resume after a delay slot at the saved next PC
>
> After single-stepping an instruction that does not branch, execution
> resumes at the saved next PC. The probed address plus 8 comes next.
> For an instruction in the delay slot of a taken branch the saved next
> PC is the branch target. Execution then goes back to the probed
> address plus 8. It should continue at the target plus 4.
>
> Use the saved next PC plus 4. For any other instruction that is the
> probed address plus 8.
>
> Link: https://github.com/sparclinux/issues/issues/110
> Signed-off-by: Stian Halseth <stian@itx.no>
[Severity: Low]
This fixes the real_pc + 0x8UL return value in relbranch_fixup(). Should
this include:
Fixes: f08825896664 ("[SPARC64]: Fix several kprobes bugs.")
--
Sashiko AI review · https://sashiko.dev/#/patchset/20261113144057.1697874-1-stian@itx.no?part=3
next prev parent reply other threads:[~2026-11-13 14:47 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-13 14:40 [PATCH v2 0/4] sparc64: kprobes: Make kprobes work on sun4v Stian Halseth
2026-11-13 14:40 ` [PATCH v2 1/4] sparc64: kprobes: Single-step from an executable instruction slot Stian Halseth
2026-11-13 14:40 ` [PATCH v2 2/4] sparc64: kprobes: Fix up register and FP branches after single-step Stian Halseth
2026-11-13 14:40 ` [PATCH v2 3/4] sparc64: kprobes: Resume after a delay slot at the saved next PC Stian Halseth
2026-11-13 14:47 ` sashiko-bot [this message]
2026-11-13 14:40 ` [PATCH v2 4/4] sparc64: kprobes: Handle annulled branches Stian Halseth
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=sashiko-outbox-213010@kernel.org \
--to=sashiko-bot@kernel.org \
--cc=linux-trace-kernel@vger.kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
--cc=sparclinux@vger.kernel.org \
--cc=stian@itx.no \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.