From: sashiko-bot@kernel.org
To: "Komal Bajaj" <komal.bajaj@oss.qualcomm.com>
Cc: devicetree@vger.kernel.org, robh@kernel.org, conor+dt@kernel.org
Subject: Re: [PATCH v5 1/3] dt-bindings: remoteproc: Move iommus constraint to SoC-specific bindings
Date: Fri, 13 Nov 2026 14:52:21 +0000 [thread overview]
Message-ID: <sashiko-outbox-213017@kernel.org> (raw)
In-Reply-To: <20261113-shikra-el2-v5-1-8aca743de97f@oss.qualcomm.com>
Thank you for your contribution! Sashiko AI review found 1 potential
issue to consider:
- [Low] dt-bindings: remoteproc: iommus defined only in allOf if/then
blocks
--
commit 1ded47577cc7fa6ba7648da8e6df9b5ccd0a3022
Author: Komal Bajaj <komal.bajaj@oss.qualcomm.com>
dt-bindings: remoteproc: Move iommus constraint to SoC-specific bindings
This commit removes the iommus property from the common PAS remoteproc
binding and adds it to the SoC-specific PAS bindings that use it.
> diff --git a/Documentation/devicetree/bindings/remoteproc/qcom,pas-common.yaml b/Documentation/devicetree/bindings/remoteproc/qcom,pas-common.yaml
> index f75cab6b4ed95..4662fe4cff62f 100644
> --- a/Documentation/devicetree/bindings/remoteproc/qcom,pas-common.yaml
> +++ b/Documentation/devicetree/bindings/remoteproc/qcom,pas-common.yaml
> @@ -32,9 +32,6 @@ properties:
> minItems: 5
> maxItems: 6
>
> - iommus:
> - maxItems: 1
> -
> power-domains:
> minItems: 1
> maxItems: 3
[ ... ]
> diff --git a/Documentation/devicetree/bindings/remoteproc/qcom,sc7180-pas.yaml b/Documentation/devicetree/bindings/remoteproc/qcom,sc7180-pas.yaml
> index b20780e5e26bd..8aebc785f2126 100644
> --- a/Documentation/devicetree/bindings/remoteproc/qcom,sc7180-pas.yaml
> +++ b/Documentation/devicetree/bindings/remoteproc/qcom,sc7180-pas.yaml
> @@ -169,6 +169,18 @@ allOf:
> - const: cx
> - const: mx
>
> + - if:
> + properties:
> + compatible:
> + enum:
> + - qcom,sc7280-adsp-pas
> + - qcom,sc7280-cdsp-pas
> + then:
> + properties:
> + iommus:
> + maxItems: 1
> + description: Firmware Stream
> +
> unevaluatedProperties: false
>
> examples:
> diff --git a/Documentation/devicetree/bindings/remoteproc/qcom,sm8150-pas.yaml b/Documentation/devicetree/bindings/remoteproc/qcom,sm8150-pas.yaml
> index 5a7c5f8c92d17..5c41c89369605 100644
> --- a/Documentation/devicetree/bindings/remoteproc/qcom,sm8150-pas.yaml
> +++ b/Documentation/devicetree/bindings/remoteproc/qcom,sm8150-pas.yaml
> @@ -178,6 +178,19 @@ allOf:
> - const: lcx
> - const: lmx
>
> + - if:
> + properties:
> + compatible:
> + contains:
> + enum:
> + - qcom,qcs615-adsp-pas
> + - qcom,qcs615-cdsp-pas
> + then:
> + properties:
> + iommus:
> + maxItems: 1
> + description: Firmware Stream
> +
> unevaluatedProperties: false
>
> examples:
> diff --git a/Documentation/devicetree/bindings/remoteproc/qcom,sm8550-pas.yaml b/Documentation/devicetree/bindings/remoteproc/qcom,sm8550-pas.yaml
> index 99e9aeeb4f62c..f838b98c43f40 100644
> --- a/Documentation/devicetree/bindings/remoteproc/qcom,sm8550-pas.yaml
> +++ b/Documentation/devicetree/bindings/remoteproc/qcom,sm8550-pas.yaml
> @@ -317,6 +317,21 @@ allOf:
> - const: mx
> - const: nsp
>
> + - if:
> + properties:
> + compatible:
> + contains:
> + enum:
> + - qcom,glymur-adsp-pas
> + - qcom,glymur-cdsp-pas
> + - qcom,x1e80100-adsp-pas
> + - qcom,x1e80100-cdsp-pas
> + then:
> + properties:
> + iommus:
> + maxItems: 1
> + description: Firmware Stream
> +
> unevaluatedProperties: false
>
> examples:
[Severity: Low]
As reported by Krzysztof Kozlowski on v4 [1], should iommus also be
declared in the top-level properties section of qcom,sc7180-pas.yaml,
qcom,sm8150-pas.yaml, and qcom,sm8550-pas.yaml (or kept with broad bounds
in qcom,pas-common.yaml)?
With iommus removed from qcom,pas-common.yaml, these three schemas define
iommus and its description only inside allOf if/then blocks, whereas
Documentation/devicetree/bindings/writing-schema.rst requires properties to
be defined in top-level properties with the broadest constraints and then
narrowed or disallowed in if/then/else blocks.
[1] https://lore.kernel.org/r/20261105-cunning-whippet-of-success-e4fd3d@quoll
--
Sashiko AI review · https://sashiko.dev/#/patchset/20261113-shikra-el2-v5-0-8aca743de97f@oss.qualcomm.com?part=1
next prev parent reply other threads:[~2026-11-13 14:52 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-13 14:32 [PATCH v5 0/3] arm64: dts: qcom: shikra: Add EL2 overlay for EVK variants Komal Bajaj
2026-11-13 14:32 ` [PATCH v5 1/3] dt-bindings: remoteproc: Move iommus constraint to SoC-specific bindings Komal Bajaj
2026-11-13 14:52 ` sashiko-bot [this message]
2026-11-13 14:32 ` [PATCH v5 2/3] dt-bindings: remoteproc: qcom,shikra-pas: Add iommus constraints Komal Bajaj
2026-11-13 14:32 ` [PATCH v5 3/3] arm64: dts: qcom: shikra: Add EL2 overlay for remoteproc SMMU mappings Komal Bajaj
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=sashiko-outbox-213017@kernel.org \
--to=sashiko-bot@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=komal.bajaj@oss.qualcomm.com \
--cc=robh@kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.