Re: [PATCH 2/7] Revert "drm/amdkfd: mark A+A VF VRAM PTEs as system memory"

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential
issue to consider:
- [Low] drm/amdkfd: revert commit message cites non-ancestor SHA
  daf19be40e04
--

commit 3e660e5d230b226dd7bb0de7b064fd710bf0e2a4
Author: Zhigang Luo <Zhigang.Luo@amd.com>

> Revert "drm/amdkfd: mark A+A VF VRAM PTEs as system memory"
>
> This reverts commit daf19be40e04.
>
> SVM VRAM ranges leave AMDGPU_PTE_SYSTEM clear and then call
> amdgpu_gmc_get_vm_pte() with a NULL buffer object. The GFX 12.1
> PTE helper sets the bit for an A+A VF, so the special case in
> svm_range_get_pte_flags() is the wrong place.
>
> Signed-off-by: Zhigang Luo <zhigang.luo@amd.com>

[Severity: Low]
Commit daf19be40e04 ("drm/amdkfd: mark A+A VF VRAM PTEs as system memory")
is not an ancestor of this branch; the commit in the branch history that
added the amdgpu_virt_vram_is_spm() check in svm_range_get_pte_flags() is
a69f4d4076ea ("drm/amdkfd: mark A+A VF VRAM PTEs as system memory").
Should the revert reference be updated to cite a69f4d4076ea ("drm/amdkfd:
mark A+A VF VRAM PTEs as system memory")?

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261113145702.323968-1-Zhigang.Luo@amd.com?part=2