Re: [PATCH v2 2/3] arm64: dts: mediatek: mt8173: Add the keypad controller

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential
issue to consider:
- [Low] arm64: dts: mediatek: undocumented mediatek,mt8173-keypad
  compatible
--

commit ab28d23b13a382f84e79c4c35213e145004742ac
Author: Ryan Brue <ryanbrue.dev@gmail.com>

arm64: dts: mediatek: mt8173: Add the keypad controller

This commit adds a disabled keypad controller node to the MT8173 SoC
device tree.

> diff --git a/arch/arm64/boot/dts/mediatek/mt8173.dtsi b/arch/arm64/boot/dts/mediatek/mt8173.dtsi
> index 2ecdea33672ea..61261fe643ab7 100644
> --- a/arch/arm64/boot/dts/mediatek/mt8173.dtsi
> +++ b/arch/arm64/boot/dts/mediatek/mt8173.dtsi
> @@ -555,6 +555,16 @@ pwrap: pwrap@1000d000 {
>  			clock-names = "spi", "wrap";
>  		};
>  
> +		keyboard: keyboard@10010000 {
> +			compatible = "mediatek,mt8173-keypad",
> +				     "mediatek,mt6779-keypad";

[Severity: Low]
Is "mediatek,mt8173-keypad" documented in
Documentation/devicetree/bindings/input/mediatek,mt6779-keypad.yaml in
this tree?  A separate patch adding the compatible string was queued in
the input tree, so until that binding update is present in the target
branch, checkpatch.pl reports UNDOCUMENTED_DT_STRING and make dtbs_check
fails schema validation on MT8173 device trees.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261113-rbrue-suez-upstreaming-amazon-suez-dts-v2-0-d3b8865fa50f@gmail.com?part=2