Re: [PATCH net-next 3/3] selftests: net: getsockopt_iter: cover tcp

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential
issue to consider:
- [Low] selftests: net: nodelay_undersize_clamped() uses optlen=1 and
  cannot test clamping vs 1-byte shrink
--

commit d0de5c7edf661839608cbe0dcd2d478b9815dc91
Author: Breno Leitao <leitao@debian.org>

selftests: net: getsockopt_iter: cover tcp

This commit adds a kselftest fixture covering do_tcp_getsockopt() across
exact, undersized, and oversized option buffers.

> diff --git a/tools/testing/selftests/net/getsockopt_iter.c b/tools/testing/selftests/net/getsockopt_iter.c
> index 2367fce226d4c..4e51c8aa6a855 100644
> --- a/tools/testing/selftests/net/getsockopt_iter.c
> +++ b/tools/testing/selftests/net/getsockopt_iter.c

[ ... ]

> @@ -1005,4 +1008,246 @@ TEST_F(tls, bad_optname)

[ ... ]

> +/* Unlike IPv4, TCP clamps the reply rather than shrinking it to a byte. */
> +TEST_F(tcp, nodelay_undersize_clamped)
> +{
> +	socklen_t optlen = 1;
> +	int val = 0;
> +
> +	ASSERT_EQ(0, getsockopt(self->fd, IPPROTO_TCP, TCP_NODELAY, &val,
> +				&optlen));
> +	ASSERT_EQ(1, optlen);
> +}

[Severity: Low]
Does passing optlen = 1 in nodelay_undersize_clamped() distinguish clamping to
optlen from shrinking a sub-int reply to a single byte?  Both min_t(unsigned
int, len, sizeof(int)) in do_tcp_getsockopt() and the single-byte fallback in
do_ip_getsockopt() report optlen == 1 when called with a 1-byte buffer, so
passing optlen = 2 or 3 is needed to test the behavior described in the
comment.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261112-getsockopt_phase7-v1-0-1eb759dd0929@debian.org?part=3