Re: [PATCH RFC 22/23] arm64: dts: qcom: sm8650-valve-deckard: enable audio

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 2 potential
issues to consider:
- [Medium] arm64: dts: qcom: sm8650-valve-deckard: missing VA DMIC1
  route in audio-routing
- [Low] arm64: dts: qcom: sm8650-valve-deckard: unused lpass_rxmacro and
  lpass_txmacro enabled
--

commit 159b85c8d3e0dd02d73b32823f4b0aaab92103dd
Author: Neil Armstrong <neil.armstrong@linaro.org>

arm64: dts: qcom: sm8650-valve-deckard: enable audio

This commit includes sm8650-lpass-cpu.dtsi and configures the SM8650 sound
card, lpass_cpu, and macro nodes to drive the speakers on Senary MI2S and
the DMICs on the VA macro.

> diff --git a/arch/arm64/boot/dts/qcom/sm8650-valve-deckard.dts b/arch/arm64/boot/dts/qcom/sm8650-valve-deckard.dts
> index a365caa28cee4..723f7911fc547 100644
> --- a/arch/arm64/boot/dts/qcom/sm8650-valve-deckard.dts
> +++ b/arch/arm64/boot/dts/qcom/sm8650-valve-deckard.dts

[ ... ]

> @@ -160,6 +161,37 @@ framebuffer_mem: framebuffer-region@af400000 {
>  		};
>  	};
>  
> +	sound: sound {
> +		compatible = "qcom,sm8650-sndcard", "qcom,sm8450-sndcard";
> +		model = "VALVE-DECKARD";
> +
> +		audio-routing = "VA DMIC0", "vdd-micb";

[Severity: Medium]
Should audio-routing also include "VA DMIC1", "vdd-micb"?

lpass_vamacro uses dmic01_default and the LPASS_CDC_DMA_VA_TX0 DAI in
sound/soc/qcom/lpass-sm8650.c sets channels_min = 2.  In
sound/soc/codecs/lpass-va-macro.c, "VA DMIC0" and "VA DMIC1" are separate
DAPM ADC widgets, so without routing "VA DMIC1" to "vdd-micb", enabling VA
DMIC1 without VA DMIC0 will not power the vdd-micb regulator supply.

> +
> +		speaker-dai-link {
> +			link-name = "SPKR Playback";
> +
> +			cpu {
> +				sound-dai = <&lpass_cpu MI2S_SENARY>;
> +			};
> +
> +			codec {
> +				sound-dai = <&left_spkr_i2s>, <&right_spkr_i2s>;
> +			};
> +		};
> +
> +		va-dai-link {
> +			link-name = "VA Capture";
> +
> +			cpu {
> +				sound-dai = <&lpass_cpu LPASS_CDC_DMA_VA_TX0>;
> +			};
> +
> +			codec {
> +				sound-dai = <&lpass_vamacro 0>;
> +			};
> +		};
> +	};

[ ... ]

> +&lpass_rxmacro {
> +	status = "okay";
> +};
> +
> +&lpass_txmacro {
> +	status = "okay";
> +};
> +
> +&lpass_vamacro {
> +	pinctrl-0 = <&dmic01_default>;
> +	pinctrl-names = "default";
> +	vdd-micb-supply = <&vreg_l10b_1p8>;
> +	qcom,dmic-sample-rate = <2400000>;
> +};

[Severity: Low]
Are lpass_rxmacro and lpass_txmacro intentionally enabled here?

The sound card only uses MI2S_SENARY and lpass_vamacro, and nothing on this
board consumes DAIs or clocks from lpass_rxmacro or lpass_txmacro.  Probing
them registers unused ASoC components and calls lpass_macro_pds_init(),
which holds active runtime PM references on the macro and dcodec power
domains for the lifetime of the drivers.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261113-topic-sm8650-el2-v1-0-5183f6aab9fc@linaro.org?part=22