Re: [CI] drm/xe/gsc: Test NVL GSC 108.0.0.1242

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential
issue to consider:
- [High] drm/xe/gsc: hardcoded CI test path in uc_fw_auto_select()
  breaks NVL GSC load
--

commit cc86bf7c798618eb51dc746674edd3c06bb1359c
Author: Daniele Ceraolo Spurio <daniele.ceraolospurio@intel.com>

drm/xe/gsc: Test NVL GSC 108.0.0.1242

This commit adds a path_ver macro to XE_GSC_FIRMWARE_DEFS to hardcode the
NOVALAKE_S GSC firmware path to xe/nvl_gsc_108.0.0.1242.bin for CI
testing.

> diff --git a/drivers/gpu/drm/xe/xe_uc_fw.c b/drivers/gpu/drm/xe/xe_uc_fw.c
> index 02aa97de6d3a7..c59a0bc9fd346 100644
> --- a/drivers/gpu/drm/xe/xe_uc_fw.c
> +++ b/drivers/gpu/drm/xe/xe_uc_fw.c
> @@ -142,8 +142,8 @@ struct fw_blobs_by_type {
>  	fw_def(TIGERLAKE,	GT_TYPE_ANY,	no_ver(i915,	huc,		tgl))
>  
>  /* for the GSC FW we match the compatibility version and not the release one */
> -#define XE_GSC_FIRMWARE_DEFS(fw_def, major_ver)		\
> -	fw_def(NOVALAKE_S,	GT_TYPE_ANY,	major_ver(xe,	gsc,	nvl,	108, 1, 0))	\
> +#define XE_GSC_FIRMWARE_DEFS(fw_def, major_ver, path_ver)		\
> +	fw_def(NOVALAKE_S,	GT_TYPE_ANY,	path_ver(xe,	gsc,	nvl,	108, 1, 0, "xe/nvl_gsc_108.0.0.1242.bin"))	\
>  	fw_def(PANTHERLAKE,	GT_TYPE_ANY,	major_ver(xe,	gsc,	ptl,	105, 1, 0))	\
>  	fw_def(LUNARLAKE,	GT_TYPE_ANY,	major_ver(xe,	gsc,	lnl,	104, 1, 0))	\
>  	fw_def(METEORLAKE,	GT_TYPE_ANY,	major_ver(i915,	gsc,	mtl,	102, 1, 0))

[Severity: High]
Will replacing the compatibility-versioned xe/nvl_gsc_1.bin entry with a
hardcoded CI release filename break GSC firmware loading on NOVALAKE_S?

On systems with standard linux-firmware packages, MODULE_FIRMWARE() no
longer advertises xe/nvl_gsc_1.bin for initramfs generation, and
uc_fw_auto_select() requests xe/nvl_gsc_108.0.0.1242.bin without falling
back to xe/nvl_gsc_1.bin.  The firmware request fails with -ENOENT, leaving
gt->uc.gsc.fw unloadable and causing xe_pxp_init() to skip PXP
initialization.

Candidate GSC firmware binaries can be tested at runtime via the existing
xe.gsc_firmware_path module parameter in uc_fw_override() without
replacing the entry in XE_GSC_FIRMWARE_DEFS.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261113192311.1455041-2-daniele.ceraolospurio@intel.com?part=1