Re: [PATCH v4 6/7] kbuild: build the tools selected in tools/Kconfig as part of "make all"

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential
issue to consider:
- [Medium] kbuild: make -n all fails in tools_build when
  CONFIG_TOOLS_BUILD_PERF=y
--

commit 0273f2e0753bd56565e4e6fbd57c3d5604e7d261
Author: Sasha Levin <sashal@kernel.org>

kbuild: build the tools selected in tools/Kconfig as part of "make all"

This commit makes the "all" target depend on "tools_build" when
CONFIG_TOOLS_BUILD is enabled so that selected tools are built during
standard kernel builds.

> diff --git a/Makefile b/Makefile
> index 7919263484f0a..2a69f4c73a641 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -1650,6 +1650,10 @@ PHONY += tools_build
>  tools_build: headers
>  	$(Q)$(MAKE) -f $(srctree)/tools/Makefile.kbuild
>  
> +ifdef CONFIG_TOOLS_BUILD
> +all: tools_build
> +endif
> +
>  # ---------------------------------------------------------------------------
>  # Kernel selftest
>  

[Severity: Medium]
Does this break "make -n all" on a clean tree when CONFIG_TOOLS_BUILD_PERF
is enabled?

Because tools_build and the "build" macro in tools/Makefile.kbuild invoke
$(MAKE), GNU Make executes them during a dry run, creating directories
under tools-build/ and descending into tools/perf/Makefile.perf:

tools/perf/Makefile.perf:
$(LIBAPI): FORCE | $(LIBAPI_OUTPUT)
	$(Q)$(MAKE) -C $(LIBAPI_DIR) O=$(LIBAPI_OUTPUT) \
		DESTDIR=$(LIBAPI_DESTDIR) prefix= subdir= \
		$@ install_headers

Under "make -n", the $(Q)$(MKDIR) -p $@ recipe for the $(LIBAPI_OUTPUT)
order-only prerequisite is skipped, while the $(LIBAPI) sub-make still
runs and aborts in tools/scripts/Makefile.include with "O=.../libapi does
not exist".

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261112195427.3411746-1-sashal@kernel.org?part=6