Re: [PATCH v2 16/30] perf test: Add CPUID matching tests for other architectures

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential
issue to consider:
- [Low] perf test: two-hyphen RISC-V strings in
  test__cpuid_match_regex()
--

commit 119e605bf598b12e6b113f6de7ea78452df71ad9
Author: Ian Rogers <irogers@google.com>

perf test: Add CPUID matching tests for other architectures

This commit adds strcmp_cpuid_str() unit tests for exact matching, x86,
PowerPC, RISC-V, and s390 CPUID strings.

> diff --git a/tools/perf/tests/cpuid-match.c b/tools/perf/tests/cpuid-match.c
> index e3d4a349f393b..826380241a0f1 100644
> --- a/tools/perf/tests/cpuid-match.c
> +++ b/tools/perf/tests/cpuid-match.c
> @@ -36,8 +36,87 @@ static int test__cpuid_match_arm64(struct test_suite *test __maybe_unused,

[ ... ]

> +static int test__cpuid_match_regex(struct test_suite *test __maybe_unused,
> +				   int subtest __maybe_unused)
> +{
> +	/* Three hyphens in a RISC-V CPUID don't imply an x86 stepping. */
> +	TEST_ASSERT_VAL("riscv match",
> +			!strcmp_cpuid_str(EM_RISCV, "0x489-0x8000000000000007-0x[[:xdigit:]]+",
> +					  "0x489-0x8000000000000007-0x0000000000000001"));

[Severity: Low]
Does the RISC-V test here actually exercise the three-hyphen x86 stepping
case described in the comment?

is_full_x86_cpuid() checks for three '-' characters, whereas both RISC-V
mvendorid-marchid-mimpid strings above contain only two hyphens and would
still match even if routed through strcmp_x86_cpuid_str().  Using a
mapcpuid pattern with a character-range hyphen (for example,
"0x489-0x8000000000000[1-7]-0x[[:xdigit:]]+") would give mapcpuid three
hyphens while cpuid has two.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261113195335.2865725-1-irogers@google.com?part=16