From: sashiko-bot@kernel.org
To: "A. Sverdlin" <alexander.sverdlin@siemens.com>,
linux-leds@vger.kernel.org
Cc: lee@kernel.org
Subject: Re: [PATCH v7 1/3] leds: trigger: netdev: Put netdev on activate error path
Date: Fri, 13 Nov 2026 20:31:25 +0000 [thread overview]
Message-ID: <sashiko-outbox-213646@kernel.org> (raw)
In-Reply-To: <20261113201936.2645736-2-alexander.sverdlin@siemens.com>
> From: Alexander Sverdlin <alexander.sverdlin@siemens.com>
>
> When hw control is active, set_device_name() takes a reference on the
> netdev via dev_get_by_name(). The register_netdevice_notifier() failure
> path frees trigger_data without dropping it, leaking the netdev.
>
> Cc: stable@vger.kernel.org
> Closes: https://lore.kernel.org/all/20260914140045.B8F4C1F000FF@smtp.kernel.org/
> Fixes: 0316cc5629d1 ("leds: trigger: netdev: init mode if hw control already active")
> Acked-by: Lee Jones <lee@kernel.org>
> Signed-off-by: Alexander Sverdlin <alexander.sverdlin@siemens.com>
Sashiko has reviewed this patch and found no issues.
--
Sashiko AI review · https://sashiko.dev/#/patchset/20261113201936.2645736-1-alexander.sverdlin@siemens.com?part=1
next prev parent reply other threads:[~2026-11-13 20:31 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-13 20:19 [PATCH v7 0/3] leds: trigger: netdev: fix sysfs_update_group() races A. Sverdlin
2026-11-13 20:19 ` [PATCH v7 1/3] leds: trigger: netdev: Put netdev on activate error path A. Sverdlin
2026-11-13 20:31 ` sashiko-bot [this message]
2026-11-13 20:19 ` [PATCH v7 2/3] leds: trigger: netdev: Fix sysfs_update_group() races A. Sverdlin
2026-11-13 20:19 ` [PATCH v7 3/3] leds: trigger: netdev: Report invalid interval to user space A. Sverdlin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=sashiko-outbox-213646@kernel.org \
--to=sashiko-bot@kernel.org \
--cc=alexander.sverdlin@siemens.com \
--cc=lee@kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.