From: sashiko-bot@kernel.org
To: "Ingo A. Kubbilun" <ingo.kubbilun@gmail.com>
Cc: linux-sound@vger.kernel.org
Subject: Re: [PATCH] ASoC: qcom: common: report line-out plugs on the Headphone Jack pin
Date: Fri, 13 Nov 2026 21:54:31 +0000 [thread overview]
Message-ID: <sashiko-outbox-213743@kernel.org> (raw)
In-Reply-To: <20261113214544.232836-1-ingo.kubbilun@gmail.com>
Thank you for your contribution! Sashiko AI review found 1 potential
issue to consider:
- [Low] ASoC: qcom: common: missing Fixes trailer for
qcom_headset_jack_pins
--
commit 0fd555bd073d8d5bb7f8b16e45526f52c4eac77a
Author: Ingo A. Kubbilun <ingo.kubbilun@gmail.com>
> ASoC: qcom: common: report line-out plugs on the Headphone Jack pin
>
> The WCD MBHC classifies high-impedance loads (above linein_th, 5 kOhm
> on wcd938x) such as active speakers as SND_JACK_LINEOUT. The
> "Headphone Jack" pin only matched SND_JACK_HEADPHONE, so the jack
> control stayed off and userspace (UCM JackControl) never switched to
> the headphone output for those loads.
>
> Seen on ASUS Vivobook S16 S3607QA (X1P42100, WCD9385): active
> speakers measured at ~20 kOhm per channel were reported as LINEOUT only.
>
> Developed with the help of an AI coding assistant (Anthropic Claude),
> which drafted the changes from the Windows ACPI tables, existing device
> trees and test logs; reviewed, built and tested on the device by the
> submitter.
>
> Signed-off-by: Ingo A. Kubbilun <ingo.kubbilun@gmail.com>
[Severity: Low]
This fixes the "Headphone Jack" pin mask in qcom_headset_jack_pins[],
which omitted SND_JACK_LINEOUT when jack pins were added. Should the
commit message include:
Fixes: 4c2c935a278e ("ASoC: qcom: common: add kcontrol to jack pins")
--
Sashiko AI review · https://sashiko.dev/#/patchset/20261113214544.232836-1-ingo.kubbilun@gmail.com?part=1
prev parent reply other threads:[~2026-11-13 21:54 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-13 21:45 [PATCH] ASoC: qcom: common: report line-out plugs on the Headphone Jack pin Ingo A. Kubbilun
2026-11-13 21:54 ` sashiko-bot [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=sashiko-outbox-213743@kernel.org \
--to=sashiko-bot@kernel.org \
--cc=ingo.kubbilun@gmail.com \
--cc=linux-sound@vger.kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.