Re: [PATCH v2 3/4] perf tool_pmu: Add schedstat events

[sashiko-bot@kernel.org]

> Add per-CPU tool PMU events backed by /proc/schedstat runqueue
> statistics:
> - schedstat_yield: Calls to sched_yield().
> - schedstat_schedule: Calls to schedule().
> - schedstat_schedule_idle: Calls to schedule() leaving the CPU idle.
> - schedstat_wake: Calls to try_to_wake_up().
> - schedstat_wake_local: Calls to try_to_wake_up() for the local CPU.
> - schedstat_runtime: Task runtime on this CPU in nanoseconds.
> - schedstat_wait: Task runqueue wait time on this CPU in nanoseconds.
> - schedstat_timeslices: Number of timeslices run on this CPU.
> 
> Because /proc/schedstat reports per-CPU runqueue counters, reject
> per-process and cgroup modes, exclude schedstat events from
> perf_pmu__reads_only_on_cpu_idx0(), and update should_skip_zero_counter()
> so zero-valued per-CPU tool events are not suppressed on CPUs > 0. Track
> [ ... ]
>   CPU1                3,535      tool/schedstat_timeslices/
> 
>          0.101808548 seconds time elapsed
> 
> Signed-off-by: Ian Rogers <irogers@google.com>

Sashiko has reviewed this patch and found no issues.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261113233739.3626499-1-irogers@google.com?part=3