Re: [PATCH RFC 1/3] PCI: rockchip-host: Skip downstream config access while link is down

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential
issue to consider:
- [Low] PCI: rockchip-host: missing Fixes trailer for link-down config
  access fix
--

commit d2a13e40a12b2c5046df485daa4e6e09d60bef0c
Author: Matt Thompson <matt@boondocker.io>

> PCI: rockchip-host: Skip downstream config access while link is down
>
> On a RockPro64, a PCI bus rescan with the downstream FPGA unavailable
> faulted in rockchip_pcie_rd_conf() during a vendor ID read. The rescan
> task exited with interrupts disabled and the watchdog reported a lockup.
>
> Check the controller's link-up and link-training status before issuing
> downstream config requests. Return PCIBIOS_DEVICE_NOT_FOUND while the
> link is unavailable. Root port config access still uses the local
> controller registers.
>
> This check cannot prevent the link from dropping during the transaction.
>
> Signed-off-by: Matt Thompson <matt@boondocker.io>

[Severity: Low]
Since this fixes a fault and lockup when rockchip_pcie_rd_other_conf() or
rockchip_pcie_wr_other_conf() accesses config space while the PCIe link is
down, should it include a Fixes: tag?

  Fixes: e77f847df54c ("PCI: rockchip: Add Rockchip PCIe controller support")

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261113-rfc-b4-v1-0-b91dcb502250@boondocker.io?part=1