Re: [PATCH 4/4] hwmon: (adt7475) Expose fan control via PWM framework

[sashiko-bot@kernel.org]

> Register the PWM outputs with the PWM framework when the node has
> "#pwm-cells", so that generic consumers such as pwm-fan can drive them,
> for example as thermal cooling devices. This follows the ADT7470
> driver. A failure to register the PWM chip fails the probe. Without
> CONFIG_PWM, no PWM chip is registered. Unlike ADT7470, the driver does
> not warn about "#pwm-cells" without CONFIG_PWM: fan-N children use the
> property too, so its presence does not imply a PWM consumer.
> CONFIG_PWM is bool, so no Kconfig dependency is needed.
> 
> The binding also documents "#pwm-cells" without a PWM consumer: fan-N
> child nodes reference the chip itself to configure a channel at probe.
> Device trees that do this keep working unchanged. Registering the PWM
> chip does not touch the hardware, and requesting a channel only marks
> it as held. Nothing changes for a channel until a consumer applies a
> waveform to it.
> [ ... ]
>   exist.
> 
> Document the PWM provider in adt7475.rst.
> 
> Signed-off-by: Davíð Steinn Geirsson <david@dsg.is>

Sashiko has reviewed this patch and found no issues.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261114004110.328050-1-david@dsg.is?part=4