From: sashiko-bot@kernel.org
To: "Chrispine Tinega" <dev@chrispinetinega.com>
Cc: devicetree@vger.kernel.org, mfd@lists.linux.dev, robh@kernel.org,
conor+dt@kernel.org, lee@kernel.org
Subject: Re: [PATCH 1/3] mfd: tps65219: Correct the MASK_EFFECT field of MASK_CONFIG
Date: Sat, 14 Nov 2026 03:29:58 +0000 [thread overview]
Message-ID: <sashiko-outbox-214112@kernel.org> (raw)
In-Reply-To: <20261114032457.3434248-2-dev@chrispinetinega.com>
Thank you for your contribution! Sashiko AI review found 1 potential
issue to consider:
- [Low] mfd: tps65219: missing Fixes trailer for
TPS65219_REG_MASK_EFFECT_MASK fix
--
commit bc69d7bd96f2d6a411ff79d868b4352a275dddc8
Author: Chrispine Tinega <dev@chrispinetinega.com>
> mfd: tps65219: Correct the MASK_EFFECT field of MASK_CONFIG
>
> MASK_EFFECT is bits 6:5 of MASK_CONFIG (0x25), per table 7-46 of the
> TPS65219 datasheet (SLVSGA0D). Bits 2:1 are the warm masks of sensors 1
> and 2. Nothing uses the macro yet, so nothing has written the wrong bits.
>
> Signed-off-by: Chrispine Tinega <dev@chrispinetinega.com>
[Severity: Low]
This fixes the TPS65219_REG_MASK_EFFECT_MASK definition. Should this
include:
Fixes: 74c17a0a49a6 ("mfd: tps65219: Add driver for TI TPS65219 PMIC")
--
Sashiko AI review · https://sashiko.dev/#/patchset/20261114032457.3434248-1-dev@chrispinetinega.com?part=1
next prev parent reply other threads:[~2026-11-14 3:29 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-14 3:24 [PATCH 0/3] mfd: tps65219: Let a board run past the warm threshold Chrispine Tinega
2026-11-14 3:24 ` [PATCH 1/3] mfd: tps65219: Correct the MASK_EFFECT field of MASK_CONFIG Chrispine Tinega
2026-11-14 3:29 ` sashiko-bot [this message]
2026-11-14 3:24 ` [PATCH 2/3] regulator: dt-bindings: ti,tps65219: Add ti,no-warm-shutdown Chrispine Tinega
2026-11-14 3:24 ` [PATCH 3/3] mfd: tps65219: Keep running past the warm threshold when asked Chrispine Tinega
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=sashiko-outbox-214112@kernel.org \
--to=sashiko-bot@kernel.org \
--cc=conor+dt@kernel.org \
--cc=dev@chrispinetinega.com \
--cc=devicetree@vger.kernel.org \
--cc=lee@kernel.org \
--cc=mfd@lists.linux.dev \
--cc=robh@kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.