Re: [PATCH v7 4/4] perf test: Test lazy symbol name loading

[sashiko-bot@kernel.org]

> From: Alireza Haghdoost <haghdoost@uber.com>
> 
> Add a "Lazy symbol loading" unit test suite. It covers duplicate
> selection without names, lazy names that take one or more reads or
> cannot be read at all, lookups from several threads while another one
> walks the symbols, eager and lazy parity on a real DSO (perf itself, or
> the one given with --dso), and a symbol table file that is replaced
> after the first name was read.
> 
> Add two shell tests. lazy_load_symbols_parity.sh runs the parity test
> on four small binaries built for the loader's corner cases: split
> debuginfo whose function section is NOBITS in the debug file, a shared
> library with .dynsym-only symbols and aliases, a stripped library with
> .gnu_debugdata, and on x86_64 an IFUNC behind an IRELATIVE PLT slot.
> script_lazy_load_symbols.sh records a small callchain profile and checks
> that perf script prints the same output with and without
> --lazy-load-symbols. As root, it also checks that names are read from
> the build-id cache when the profiled process is in another mount
> namespace.
> 
> Both shell tests skip a case, rather than fail it, when the toolchain
> produced a file whose names perf loads eagerly anyway (PPC64 ELFv1 .opd,
> .gnu_debugdata or a compressed .strtab).
> 
> Signed-off-by: Alireza Haghdoost <haghdoost@uber.com>

Sashiko has reviewed this patch and found no issues.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261113-perf-symbol-memory-send-v7-0-d992eced9f9c@uber.com?part=4