Re: [PATCH v3 3/6] mm/slab: Support disabling SLAB_BUCKETS at boot

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential
issue to consider:
- [Low] mm/slab: setup_slab_buckets() adds per-feature knob instead of
  slab_hardening
--

commit d1769f1af5f0bdc819b4474cbb49e0bbed23c8ff
Author: Chris Down <chris@chrisdown.name>

mm/slab: Support disabling SLAB_BUCKETS at boot

This commit adds a slab_buckets= early boot parameter to allow disabling
separate kmalloc buckets on kernels built with CONFIG_SLAB_BUCKETS=y.

> diff --git a/mm/slab_common.c b/mm/slab_common.c
> index 01c64ef661e7f..272d22f411c2c 100644
> --- a/mm/slab_common.c
> +++ b/mm/slab_common.c
> @@ -410,6 +410,16 @@ EXPORT_SYMBOL(__kmem_cache_create_args);
>  
>  static struct kmem_cache *kmem_buckets_cache __ro_after_init;
>  
> +static bool slab_buckets_enabled __ro_after_init = IS_ENABLED(CONFIG_SLAB_BUCKETS);
> +
> +static int __init setup_slab_buckets(char *str)
> +{
> +	if (!IS_ENABLED(CONFIG_SLAB_BUCKETS))
> +		return 0;
> +	return kstrtobool(str, &slab_buckets_enabled);
> +}
> +early_param("slab_buckets", setup_slab_buckets);

[Severity: Low]
As reported by Harry Yoo on v1 [1], should boot-time slab hardening controls
use a single coarse-grained parameter such as slab_hardening= rather than
introducing separate per-feature knobs like slab_buckets= here and
kmalloc_partition= in commit "mm/slab: Support disabling
KMALLOC_PARTITION_CACHES at boot"?

[1] https://lore.kernel.org/r/auIN44CnAyzvR_Ll@thinkstation

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/cover.1794506262.git.chris@chrisdown.name?part=3