From: sashiko-bot@kernel.org
To: "Vishnu Saini" <vishnu.saini@oss.qualcomm.com>
Cc: devicetree@vger.kernel.org, robh@kernel.org, conor+dt@kernel.org
Subject: Re: [PATCH v2] arm64: dts: qcom: monaco-arduino-monza: Add Waveshare 8" DSI touch overlay
Date: Sat, 14 Nov 2026 09:43:28 +0000 [thread overview]
Message-ID: <sashiko-outbox-214332@kernel.org> (raw)
In-Reply-To: <20261114-monza_waveshare_dtso-v2-1-d35703f59832@oss.qualcomm.com>
Thank you for your contribution! Sashiko AI review found 1 potential
issue to consider:
- [High] arm64: dts: qcom: Makefile: monaco-el2.dtbo applied to non-EL2
Waveshare DTB
--
commit fb42e57888d978dabeca7a2682d11658ae75d3e6
Author: Vishnu Saini <vishnu.saini@oss.qualcomm.com>
arm64: dts: qcom: monaco-arduino-monza: Add Waveshare 8" DSI touch overlay
This commit adds a device tree overlay to support the Waveshare 8" DSI
TOUCH-A display and touchscreen on the Qualcomm Monaco Arduino Monza
platform via the JMEDIA carrier card.
> diff --git a/arch/arm64/boot/dts/qcom/Makefile b/arch/arm64/boot/dts/qcom/Makefile
> index 8329c06b60a3f..331ae62494e57 100644
> --- a/arch/arm64/boot/dts/qcom/Makefile
> +++ b/arch/arm64/boot/dts/qcom/Makefile
> @@ -83,6 +83,11 @@ dtb-$(CONFIG_ARCH_QCOM) += monaco-arduino-monza.dtb
> monaco-arduino-monza-el2-dtbs := monaco-arduino-monza.dtb monaco-el2.dtbo
>
> dtb-$(CONFIG_ARCH_QCOM) += monaco-arduino-monza-el2.dtb
> +
> +monaco-arduino-monza-waveshare-8-dsi-touch-a-dtbs := monaco-arduino-monza.dtb monaco-el2.dtbo monaco-arduino-monza-waveshare-8-dsi-touch-a.dtbo
> +dtb-$(CONFIG_ARCH_QCOM) += monaco-arduino-monza-waveshare-8-dsi-touch-a.dtb
> +dtb-$(CONFIG_ARCH_QCOM) += monaco-arduino-monza-waveshare-8-dsi-touch-a.dtbo
[Severity: High]
Should monaco-arduino-monza-waveshare-8-dsi-touch-a-dtbs omit
monaco-el2.dtbo?
monaco-arduino-monza.dtb boots at EL1 under the Gunyah hypervisor by
default, whereas monaco-el2.dtbo is only for the explicit -el2 target.
Merging monaco-el2.dtbo into the non-EL2 composite DTB disables
gpu_zap_shader and iris and attaches EL2-only apps_smmu IOMMU stream
mappings to remoteproc_adsp, remoteproc_cdsp, and remoteproc_gpdsp:
arch/arm64/boot/dts/qcom/monaco-el2.dtso:
&gpu_zap_shader {
status = "disabled";
};
&iris {
status = "disabled";
};
&remoteproc_adsp {
iommus = <&apps_smmu 0x2000 0x0>;
};
When booting monaco-arduino-monza-waveshare-8-dsi-touch-a.dtb in the
default EL1 mode, GPU zap shader loading and Iris video acceleration are
disabled and the direct IOMMU mappings on the remoteprocs conflict with
Gunyah PAS management.
--
Sashiko AI review · https://sashiko.dev/#/patchset/20261114-monza_waveshare_dtso-v2-1-d35703f59832@oss.qualcomm.com?part=1
prev parent reply other threads:[~2026-11-14 9:43 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-14 9:13 [PATCH v2] arm64: dts: qcom: monaco-arduino-monza: Add Waveshare 8" DSI touch overlay Vishnu Saini
2026-11-14 9:43 ` sashiko-bot [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=sashiko-outbox-214332@kernel.org \
--to=sashiko-bot@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=robh@kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
--cc=vishnu.saini@oss.qualcomm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.